[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/11] block/export: convert vhost-user-blk server to block e
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 11/11] block/export: convert vhost-user-blk server to block export API |
Date: |
Wed, 23 Sep 2020 19:29:24 +0100 |
On Wed, Sep 23, 2020 at 03:42:30PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
>
> > Use the new QAPI block exports API instead of defining our own QOM
> > objects.
> >
> > This is a large change because the lifecycle of VuBlockDev needs to
> > follow BlockExportDriver. QOM properties are replaced by QAPI options
> > objects.
> >
> > VuBlockDev is renamed VuBlkExport and contains a BlockExport field.
> > Several fields can be dropped since BlockExport already has equivalents.
> >
> > The file names and meson build integration will be adjusted in a future
> > patch. libvhost-user should probably be built as a static library that
> > is linked into QEMU instead of as a .c file that results in duplicate
> > compilation.
> >
> > The new command-line syntax is:
> >
> > $ qemu-storage-daemon \
> > --blockdev file,node-name=drive0,filename=test.img \
> > --export
> > vhost-user-blk,node-name=drive0,id=export0,unix-socket=/tmp/vhost-user-blk.sock
> >
> > Note that unix-socket is optional because we may wish to accept chardevs
> > too in the future.
>
> It's optional in the QAPI schema, but the code cosunming the --export
> appears to require it.
>
> There is no need to make it optional now just in case: Changing an
> option parameter from mandatory to optional is backward-compatible.
Good point, it should be mandatory.
Stefan
signature.asc
Description: PGP signature
- [PATCH 00/11] block/export: convert vhost-user-blk-server to block exports API, Stefan Hajnoczi, 2020/09/22
- [PATCH 01/11] block/export: shorten serial string to fit, Stefan Hajnoczi, 2020/09/22
- [PATCH 02/11] util/vhost-user-server: s/fileds/fields/ typo fix, Stefan Hajnoczi, 2020/09/22
- [PATCH 08/11] util/vhost-user-server: check EOF when reading payload, Stefan Hajnoczi, 2020/09/22
- [PATCH 09/11] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle, Stefan Hajnoczi, 2020/09/22
- [PATCH 10/11] block/export: report flush errors, Stefan Hajnoczi, 2020/09/22
- [PATCH 11/11] block/export: convert vhost-user-blk server to block export API, Stefan Hajnoczi, 2020/09/22
- [PATCH 04/11] util/vhost-user-server: drop unnecessary watch deletion, Stefan Hajnoczi, 2020/09/22
- [PATCH 05/11] block/export: consolidate request structs into VuBlockReq, Stefan Hajnoczi, 2020/09/22
- [PATCH 06/11] util/vhost-user-server: drop unused DevicePanicNotifier, Stefan Hajnoczi, 2020/09/22
- [PATCH 03/11] util/vhost-user-server: drop unnecessary QOM cast, Stefan Hajnoczi, 2020/09/22
- [PATCH 07/11] util/vhost-user-server: fix memory leak in vu_message_read(), Stefan Hajnoczi, 2020/09/22