[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] softfloat: Tidy a * b + inf return
From: |
David Hildenbrand |
Subject: |
Re: [PATCH 3/8] softfloat: Tidy a * b + inf return |
Date: |
Thu, 24 Sep 2020 09:37:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 24.09.20 03:24, Richard Henderson wrote:
> No reason to set values in 'a', when we already
> have float_class_inf in 'c', and can flip that sign.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> fpu/softfloat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 67cfa0fd82..9db55d2b11 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1380,9 +1380,8 @@ static FloatParts muladd_floats(FloatParts a,
> FloatParts b, FloatParts c,
> s->float_exception_flags |= float_flag_invalid;
> return parts_default_nan(s);
> } else {
> - a.cls = float_class_inf;
> - a.sign = c.sign ^ sign_flip;
> - return a;
> + c.sign ^= sign_flip;
> + return c;
> }
> }
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
- [PATCH 0/8] softfloat: Implement float128_muladd, Richard Henderson, 2020/09/23
- [PATCH 1/8] softfloat: Use mulu64 for mul64To128, Richard Henderson, 2020/09/23
- [PATCH 2/8] softfloat: Use int128.h for some operations, Richard Henderson, 2020/09/23
- [PATCH 3/8] softfloat: Tidy a * b + inf return, Richard Henderson, 2020/09/23
- Re: [PATCH 3/8] softfloat: Tidy a * b + inf return,
David Hildenbrand <=
- [PATCH 4/8] softfloat: Add float_cmask and constants, Richard Henderson, 2020/09/23
- [PATCH 5/8] softfloat: Inline pick_nan_muladd into its caller, Richard Henderson, 2020/09/23
- [PATCH 6/8] softfloat: Implement float128_muladd, Richard Henderson, 2020/09/23
- [PATCH 7/8] softfloat: Use x86_64 assembly for {add,sub}{192,256}, Richard Henderson, 2020/09/23
- [PATCH 8/8] softfloat: Use aarch64 assembly for {add,sub}{192,256}, Richard Henderson, 2020/09/23