[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v26 17/17] qapi: Add VFIO devices migration stats in Migratio
From: |
Eric Blake |
Subject: |
Re: [PATCH v26 17/17] qapi: Add VFIO devices migration stats in Migration stats |
Date: |
Thu, 24 Sep 2020 10:14:09 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/22/20 6:24 PM, Kirti Wankhede wrote:
Added amount of bytes transferred to the target VM by all VFIO devices
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
---
Note: Comments from v25 for this patch are not addressed yet.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg715620.html
Alex, need more pointer on documentation part raised Markus Armbruster.
+++ b/qapi/migration.json
@@ -147,6 +147,18 @@
'active', 'postcopy-active', 'postcopy-paused',
'postcopy-recover', 'completed', 'failed', 'colo',
'pre-switchover', 'device', 'wait-unplug' ] }
+##
+# @VfioStats:
+#
+# Detailed VFIO devices migration statistics
+#
+# @transferred: amount of bytes transferred to the target VM by VFIO devices
+#
+# Since: 5.1
This should be Since: 5.2
+#
+##
+{ 'struct': 'VfioStats',
+ 'data': {'transferred': 'int' } }
##
# @MigrationInfo:
@@ -208,11 +220,16 @@
#
# @socket-address: Only used for tcp, to know what the real port is (Since
4.0)
#
+# @vfio: @VfioStats containing detailed VFIO devices migration statistics,
+# only returned if VFIO device is present, migration is supported by all
+# VFIO devices and status is 'active' or 'completed' (since 5.1)
and here
+#
# Since: 0.14.0
##
{ 'struct': 'MigrationInfo',
'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats',
'*disk': 'MigrationStats',
+ '*vfio': 'VfioStats',
'*xbzrle-cache': 'XBZRLECacheStats',
'*total-time': 'int',
'*expected-downtime': 'int',
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v26 12/17] vfio: Add function to start and stop dirty pages tracking, (continued)
- [PATCH v26 12/17] vfio: Add function to start and stop dirty pages tracking, Kirti Wankhede, 2020/09/22
- [PATCH v26 11/17] vfio: Get migration capability flags for container, Kirti Wankhede, 2020/09/22
- [PATCH v26 13/17] vfio: create mapped iova list when vIOMMU is enabled, Kirti Wankhede, 2020/09/22
- [PATCH v26 14/17] vfio: Add vfio_listener_log_sync to mark dirty pages, Kirti Wankhede, 2020/09/22
- [PATCH v26 15/17] vfio: Add ioctl to get dirty pages bitmap during dma unmap., Kirti Wankhede, 2020/09/22
- [PATCH v26 16/17] vfio: Make vfio-pci device migration capable, Kirti Wankhede, 2020/09/22
- [PATCH v26 17/17] qapi: Add VFIO devices migration stats in Migration stats, Kirti Wankhede, 2020/09/22
- Re: [PATCH QEMU v25 00/17] Add migration support for VFIO devices, Zenghui Yu, 2020/09/23