|
From: | John Snow |
Subject: | Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py |
Date: | Thu, 24 Sep 2020 12:20:47 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/23/20 8:00 PM, Eric Blake wrote:
There's enough grammar fixes, and the fact that John is working on python cleanups, to make me wonder if we need a v9, or if I should just stage it where it is with any other cleanups as followups. But I'm liking the reduced maintenance burden once it is in, and don't want to drag it out to the point that it needs more rebasing as other things land first.
Don't worry about it too much. I'd rather we have a helpful script sooner than later than worry about Python style purity before I have the CI mechanisms for it fully established.
(I eyeballed it and it looks like you already use type hints, so I have faith it won't need much cleanup.)
Thanks! --js
[Prev in Thread] | Current Thread | [Next in Thread] |