[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] audio: restore mixing-engine playback buffer size
From: |
Volker Rümelin |
Subject: |
Re: [PATCH 8/9] audio: restore mixing-engine playback buffer size |
Date: |
Thu, 24 Sep 2020 19:42:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
>> diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
>> index 21b7a0484b..cb931d0fda 100644
>> --- a/audio/sdlaudio.c
>> +++ b/audio/sdlaudio.c
>> @@ -253,6 +253,7 @@ static void sdl_callback (void *opaque, Uint8 *buf, int
>> len)
>> return ret; \
>> }
>>
>> +SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
>> SDL_WRAPPER_FUNC(get_buffer_out, void *, (HWVoiceOut *hw, size_t *size),
>> (hw, size), *size = 0, sdl_unlock)
>> SDL_WRAPPER_FUNC(put_buffer_out, size_t,
> Compiling C object libcommon.fa.p/audio_sdlaudio.c.o
> ../../audio/sdlaudio.c:256:65: error: macro "SDL_WRAPPER_FUNC" requires 6
> arguments, but only 4 given
> 256 | SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
> | ^
> ../../audio/sdlaudio.c:243: note: macro "SDL_WRAPPER_FUNC" defined here
> 243 | #define SDL_WRAPPER_FUNC(name, ret_type, args_decl, args, fail,
> unlock) \
> |
> ../../audio/sdlaudio.c:256:17: error: expected ‘;’ before ‘static’
> 256 | SDL_WRAPPER_FUNC(buffer_get_free, size_t, (HWVoiceOut *hw), (hw))
> | ^
> | ;
> ../../audio/sdlaudio.c:355:24: error: ‘sdl_buffer_get_free’ undeclared here
> (not in a function)
> 355 | .buffer_get_free = sdl_buffer_get_free,
> | ^~~~~~~~~~~~~~~~~~~
> make: *** [Makefile.ninja:1113: libcommon.fa.p/audio_sdlaudio.c.o] Error 1
>
> (I think coreaudio has the same problem ...).
>
> take care,
> Gerd
>
Sorry. This was caused by a bad rebase and my tests were insufficient. I guess
I'll send my sdlaudio patches next. This patch has to wait.
With best regards,
Volker
- [PATCH 0/9] Audio fixes and improvements, Volker Rümelin, 2020/09/20
- [PATCH 1/9] audio: handle buf == NULL in put_buffer_out(), Volker Rümelin, 2020/09/20
- [PATCH 3/9] audio/spiceaudio: always rate limit playback stream, Volker Rümelin, 2020/09/20
- [PATCH 2/9] audio/audio: fix video playback slowdown with spiceaudio, Volker Rümelin, 2020/09/20
- [PATCH 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in, Volker Rümelin, 2020/09/20
- [PATCH 7/9] audio: run downstream playback queue unconditionally, Volker Rümelin, 2020/09/20
- [PATCH 8/9] audio: restore mixing-engine playback buffer size, Volker Rümelin, 2020/09/20
- [PATCH 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out, Volker Rümelin, 2020/09/20
- [PATCH 5/9] audio: remove unnecessary calls to put_buffer_in, Volker Rümelin, 2020/09/20
- [PATCH 9/9] audio: revert tests for pcm_ops table, Volker Rümelin, 2020/09/20
- Re: [PATCH 0/9] Audio fixes and improvements, Gerd Hoffmann, 2020/09/23