[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/14] hw/block/nvme: Add support for active/inactive name
From: |
Niklas Cassel |
Subject: |
Re: [PATCH v4 06/14] hw/block/nvme: Add support for active/inactive namespaces |
Date: |
Thu, 24 Sep 2020 19:40:48 +0000 |
On Thu, Sep 24, 2020 at 08:55:24PM +0200, Klaus Jensen wrote:
> On Sep 24 18:17, Niklas Cassel wrote:
> > On Thu, Sep 24, 2020 at 02:12:03PM +0200, Klaus Jensen wrote:
> > > On Sep 24 03:20, Dmitry Fomichev wrote:
> > > > From: Niklas Cassel <niklas.cassel@wdc.com>
> > > >
> > > > E.g., if the user sets CC.CSS to Admin Only, NVM namespaces should be
> > > > marked as inactive.
> > > >
> > >
> > > Hmm. I'm not convinced that this is correct. Can you reference the spec?
> > >
> >
> > CC.CSS can only be changed when the controller is disabled.
>
> Right. I think I see you point. While the controller is disabled, the
> host obviously cannot even see what namespaces are available, so the
> controller is free to only expose (aka, attach) the namespaces that
> makes sense for the value of CC.CSS.
>
> OK then, the patch is good :)
That was my thought, that the controller internally would
detach unsupported namespaces (even if the controller didn't
expose namespace management capabilities to the user).
This was how I assumed that things worked, but if we should
follow the spec strictly, we should do like you suggested
and keep them attached, and return the proper error code,
on non-admin commands.
Thank you for improving my understanding.
Considering that CC.CSS can only be changed when the controller
is disabled, I still kind of wished that the spec said that
unsupported namespaces would be automatically detached.
Kind regards,
Niklas
- [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set, Dmitry Fomichev, 2020/09/23
- [PATCH v4 02/14] hw/block/nvme: Add Commands Supported and Effects log, Dmitry Fomichev, 2020/09/23
- [PATCH v4 01/14] hw/block/nvme: Report actual LBA data shift in LBAF, Dmitry Fomichev, 2020/09/23
- [PATCH v4 03/14] hw/block/nvme: Introduce the Namespace Types definitions, Dmitry Fomichev, 2020/09/23
- [PATCH v4 04/14] hw/block/nvme: Define trace events related to NS Types, Dmitry Fomichev, 2020/09/23
- [PATCH v4 06/14] hw/block/nvme: Add support for active/inactive namespaces, Dmitry Fomichev, 2020/09/23
[PATCH v4 07/14] hw/block/nvme: Make Zoned NS Command Set definitions, Dmitry Fomichev, 2020/09/23
[PATCH v4 05/14] hw/block/nvme: Add support for Namespace Types, Dmitry Fomichev, 2020/09/23
[PATCH v4 08/14] hw/block/nvme: Define Zoned NS Command Set trace events, Dmitry Fomichev, 2020/09/23
[PATCH v4 10/14] hw/block/nvme: Introduce max active and open zone limits, Dmitry Fomichev, 2020/09/23
[PATCH v4 12/14] hw/block/nvme: Add injection of Offline/Read-Only zones, Dmitry Fomichev, 2020/09/23
[PATCH v4 09/14] hw/block/nvme: Support Zoned Namespace Command Set, Dmitry Fomichev, 2020/09/23
[PATCH v4 11/14] hw/block/nvme: Support Zone Descriptor Extensions, Dmitry Fomichev, 2020/09/23
[PATCH v4 13/14] hw/block/nvme: Use zone metadata file for persistence, Dmitry Fomichev, 2020/09/23
[PATCH v4 14/14] hw/block/nvme: Document zoned parameters in usage text, Dmitry Fomichev, 2020/09/23