[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 34/47] qapi/gen.py: Remove unused parameter
From: |
John Snow |
Subject: |
[PATCH v3 34/47] qapi/gen.py: Remove unused parameter |
Date: |
Thu, 24 Sep 2020 20:28:47 -0400 |
module_basename doesn't use the 'what' argument, so remove it.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
scripts/qapi/gen.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index eec941074b..ece908a058 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -265,7 +265,7 @@ def _is_user_module(name: Optional[str]) -> bool:
def _is_builtin_module(name: Optional[str]) -> bool:
return not name
- def _module_dirname(self, what: str, name: Optional[str]) -> str:
+ def _module_dirname(self, name: Optional[str]) -> str:
if self._is_user_module(name):
return os.path.dirname(name)
return ''
@@ -283,7 +283,7 @@ def _module_basename(self, what: str, name: Optional[str])
-> str:
return ret
def _module_filename(self, what: str, name: Optional[str]) -> str:
- return os.path.join(self._module_dirname(what, name),
+ return os.path.join(self._module_dirname(name),
self._module_basename(what, name))
def _add_module(self, name: Optional[str], blurb: str) -> None:
--
2.26.2
- [PATCH v3 35/47] qapi/gen.py: update write() to be more idiomatic, (continued)
- [PATCH v3 35/47] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/09/24
- [PATCH v3 27/47] qapi/commands.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 36/47] qapi/gen.py: delint with pylint, John Snow, 2020/09/24
- [PATCH v3 21/47] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/09/24
- [PATCH v3 41/47] qapi/introspect.py: replace 'extra' dict with 'comment' argument, John Snow, 2020/09/24
- [PATCH v3 43/47] qapi/types.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 28/47] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/24
- [PATCH v3 26/47] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/24
- [PATCH v3 29/47] qapi/source.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 34/47] qapi/gen.py: Remove unused parameter,
John Snow <=
- [PATCH v3 18/47] qapi/common.py: Replace one-letter 'c' variable, John Snow, 2020/09/24
- [PATCH v3 30/47] qapi/source.py: delint with pylint, John Snow, 2020/09/24
- [PATCH v3 37/47] qapi/introspect.py: assert obj is a dict when features are given, John Snow, 2020/09/24
- [PATCH v3 45/47] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/09/24
- [PATCH v3 31/47] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/09/24
- [PATCH v3 39/47] qapi/introspect.py: add _gen_features helper, John Snow, 2020/09/24
- [PATCH v3 47/47] qapi/visit.py: add type hint annotations, John Snow, 2020/09/24
- [PATCH v3 42/47] qapi/introspect.py: create a typed 'Node' data structure, John Snow, 2020/09/24
- [PATCH v3 40/47] qapi/introspect.py: Unify return type of _make_tree(), John Snow, 2020/09/24