[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 04/15] migration: Silence compiler warning in global_state_sto
From: |
Alex Bennée |
Subject: |
[PATCH v1 04/15] migration: Silence compiler warning in global_state_store_running() |
Date: |
Fri, 25 Sep 2020 16:40:16 +0100 |
From: Thomas Huth <thuth@redhat.com>
GCC 9.3.0 on Ubuntu complains:
In file included from /usr/include/string.h:495,
from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
from ../migration/global_state.c:13:
In function ‘strncpy’,
inlined from ‘global_state_store_running’ at
../migration/global_state.c:47:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error:
‘__builtin_strncpy’ specified bound 100 equals destination size
[-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... but we apparently really want to do a strncpy here - the size is already
checked with the assert() statement right in front of it. To silence the
warning, simply replace it with our strpadcpy() function.
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (two years ago)
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200918103430.297167-4-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
migration/global_state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/global_state.c b/migration/global_state.c
index 25311479a4bd..a33947ca32b5 100644
--- a/migration/global_state.c
+++ b/migration/global_state.c
@@ -44,8 +44,8 @@ void global_state_store_running(void)
{
const char *state = RunState_str(RUN_STATE_RUNNING);
assert(strlen(state) < sizeof(global_state.runstate));
- strncpy((char *)global_state.runstate,
- state, sizeof(global_state.runstate));
+ strpadcpy((char *)global_state.runstate, sizeof(global_state.runstate),
+ state, '\0');
}
bool global_state_received(void)
--
2.20.1
- [PATCH v1 00/15] testing/next pre-PR (python3.6, check-tcg), Alex Bennée, 2020/09/25
- [PATCH v1 02/15] meson: move libudev test, Alex Bennée, 2020/09/25
- [PATCH v1 04/15] migration: Silence compiler warning in global_state_store_running(),
Alex Bennée <=
- [PATCH v1 01/15] tests/tcg: reinstate or replace desired parts of rules.mak, Alex Bennée, 2020/09/25
- [PATCH v1 07/15] travis.yml: Drop the superfluous Python 3.6 build, Alex Bennée, 2020/09/25
- [PATCH v1 09/15] tests/docker: Use Fedora containers for MinGW cross-builds in the gitlab-CI, Alex Bennée, 2020/09/25
- [PATCH v1 05/15] travis.yml: Drop the default softmmu builds, Alex Bennée, 2020/09/25
- [PATCH v1 03/15] meson: move libmpathpersist test, Alex Bennée, 2020/09/25