|
From: | John Snow |
Subject: | Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table |
Date: | Fri, 25 Sep 2020 13:04:02 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/25/20 12:38 PM, Cleber Rosa wrote:
On Thu, Sep 24, 2020 at 09:32:05PM -0400, John Snow wrote:On 9/24/20 9:18 PM, Cleber Rosa wrote:I have to say the style of this line bothers me, but it's just that, style. So,What don't you like?It's the sum of the "private" + "global dictionary" + "its item being called directly". But don't bother, this is probably the kind of comment that I should omit, as I don't want you to, say, create a wrapper function around the dict, partially defeating the purpose of this patch.
ACK, just wanted to know what the style nit was. Thanks :) --js
[Prev in Thread] | Current Thread | [Next in Thread] |