[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribu
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' |
Date: |
Mon, 28 Sep 2020 18:49:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 28/09/20 16:39, Daniel P. Berrangé wrote:
> Looks like 2.58.0, which is still a fair bit newer than our 2.48 min.
>
> NB, only the macro changed - they were using GNU printf impl for many
> many years before that but simply had the wrong macro definition
>
> We can just sacrifice -Wformat checking for Windows builds when using
> old GLib. People building natively on Windows with MSys probably have
> brand new GLib, and those using Fedora mingw / Debian MXE also have
> pretty new GLib.
In the past we also had different minimal GLib versions for Windows and
POSIX systems.
Paolo
[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler, Philippe Mathieu-Daudé, 2020/09/28
[PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6, Philippe Mathieu-Daudé, 2020/09/28