[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit()
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() |
Date: |
Wed, 30 Sep 2020 09:08:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 30/09/2020 00.43, Philippe Mathieu-Daudé wrote:
> Since the support of SYS_READC in commit 8de702cb67 the
> semihosting code is strongly depedent of the TCG accelerator
> via a call to cpu_loop_exit().
>
> Ideally we would only build semihosting support when TCG
> is available, but unfortunately this is not trivial because
> semihosting is used by many targets in different configurations.
> For now add a simple stub to avoid link failure when building
> with --disable-tcg:
>
> hw/semihosting/console.c:160: undefined reference to `cpu_loop_exit'
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> accel/stubs/tcg-stub.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index e4bbf997aa..1eec7fb90e 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -29,3 +29,8 @@ void *probe_access(CPUArchState *env, target_ulong addr,
> int size,
> /* Handled by hardware accelerator. */
> g_assert_not_reached();
> }
> +
> +void cpu_loop_exit(CPUState *cpu)
> +{
> + g_assert_not_reached();
> +}
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH v4 00/12] Support disabling TCG on ARM (part 2), Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit(), Philippe Mathieu-Daudé, 2020/09/29
- Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit(),
Thomas Huth <=
- [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 05/12] target/arm: Restrict ARMv5 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 06/12] target/arm: Restrict ARMv6 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 07/12] target/arm: Restrict ARMv7 R-profile cpus to TCG accel, Philippe Mathieu-Daudé, 2020/09/29
- [PATCH v4 08/12] target/arm: Restrict ARMv7 M-profile cpus to TCG accel, Philippe Mathieu-Daudé, 2020/09/29