Re: [PATCH] tcg: Fix execution on Apple Silicon

[no-reply]

Patchew URL: 
20210102122101.39617-1-r.bolshakov@yadro.com/">https://patchew.org/QEMU/20210102122101.39617-1-r.bolshakov@yadro.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210102122101.39617-1-r.bolshakov@yadro.com
Subject: [PATCH] tcg: Fix execution on Apple Silicon

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201215064200.28751-1-jiaxun.yang@flygoat.com -> 
patchew/20201215064200.28751-1-jiaxun.yang@flygoat.com
 - [tag update]      
patchew/20201225201956.692861-1-richard.henderson@linaro.org -> 
patchew/20201225201956.692861-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210102122101.39617-1-r.bolshakov@yadro.com -> 
patchew/20210102122101.39617-1-r.bolshakov@yadro.com
Switched to a new branch 'test'
3286c7e tcg: Fix execution on Apple Silicon

=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#80: FILE: accel/tcg/translate-all.c:1075:
+#if defined(__APPLE__) && defined(__aarch64__)

WARNING: architecture specific defines should be avoided
#101: FILE: accel/tcg/translate-all.c:2731:
+#if defined(__APPLE__) && defined(__aarch64__)

ERROR: space required before the open brace '{'
#104: FILE: accel/tcg/translate-all.c:2734:
+    if (pthread_jit_write_protect_supported_np()){

total: 1 errors, 2 warnings, 104 lines checked

Commit 3286c7e4aef9 (tcg: Fix execution on Apple Silicon) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210102122101.39617-1-r.bolshakov@yadro.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210102122101.39617-1-r.bolshakov@yadro.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com