Re: [PATCH v2 3/3] nvdimm: honor -object memory-backend-file, readonly=on option

[Stefan Hajnoczi]

On Mon, Dec 14, 2020 at 12:19:05PM +0100, Igor Mammedov wrote:
> On Wed, 16 Sep 2020 10:51:50 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> > index e1574bc07c..848cd65917 100644
> > --- a/hw/mem/nvdimm.c
> > +++ b/hw/mem/nvdimm.c
> > @@ -146,6 +146,10 @@ static void nvdimm_prepare_memory_region(NVDIMMDevice 
> > *nvdimm, Error **errp)
> >          return;
> >      }
> >  
> > +    if (memory_region_is_rom(mr)) {
> > +        nvdimm->unarmed = true; /* this device is read-only */
> > +    }
> we probably should error out in case 'backend,readonly=true + 
> nvdimm,unarmed=false'
> instead of silently ignoring user's input

Will fix.

signature.asc
Description: PGP signature