Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

[Roman Bolshakov]

On Sat, Jan 09, 2021 at 01:25:44PM +0100, Christian Schoenebeck via wrote:
> On Samstag, 9. Januar 2021 00:13:36 CET BALATON Zoltan wrote:
> > On Sat, 9 Jan 2021, Roman Bolshakov wrote:
> > > On Fri, Jan 08, 2021 at 03:00:07PM +0000, Peter Maydell wrote:
> > >> On Fri, 8 Jan 2021 at 13:50, Peter Maydell <peter.maydell@linaro.org> 
> wrote:
> > >>> On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov <r.bolshakov@yadro.com> 
> wrote:
> > >>>> ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first
> > >>>> deprecated in macOS 11.0 - Use -[NSWorkspace openURL:] instead.>>>> 
> > >>>>       [-Wdeprecated-declarations]
> > >>>>       
> > >>>>         if ([[NSWorkspace sharedWorkspace] openFile: full_file_path] ==
> > >>>>         YES) {
> > >>>>         
> > >>>>                                            ^
> > >>>> 
> > >>>> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/
> Frameworks/AppKit.framework/Headers/NSWorkspace.h:350:1: note:
> > >>>>       'openFile:' has been explicitly marked deprecated here
> > >>>> 
> > >>>> - (BOOL)openFile:(NSString *)fullPath API_DEPRECATED("Use -[NSWorkspace
> > >>>> openURL:] instead.", macos(10.0, 11.0)); ^
> > >>>> 
> > >>>> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> > >>>> ---
> > >>> 
> > >>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > >> 
> > >> So I was just trying to test this patch, and I found that at least
> > >> for me the osx menu bar has stopped working in QEMU -- keyboard
> > >> shortcuts to it still work but none of the menu buttons respond
> > >> to the mouse. Does that happen for anybody else?
> > > 
> > > There's an old bug when QEMU menu bar is not responsive because it's not
> > > properly activated. If you click off qemu and click on the qemu dock
> > > icon then it "gets fixed" (cmd-tab works too). Do you hit the issue as
> > > described in the article [1]? The code in the article does exactly the
> > > same what I'm doing manually. I wanted to fix it but somehow it got
> > > postponed for like a whole year :) I might try to make a fix this but
> > > note, the issue is not related to the patch.
> > 
> > This does not sound like the best solution to the problem. There's some
> > info on this here (and blog post linked from it):
> > 
> > https://stackoverflow.com/questions/7460092/nswindow-makekeyandorderfront-ma
> > kes-window-appear-but-not-key-or-front
> > 
> > Maybe we call makeKeyAndOrderFront: too early before the app is active and
> > that's causing the problem? Would it work better if that's moved after
> > [NSApp run]? (Maybe we also need canBecomeKey: somewhere but I don't see
> > why would that be needed for normal windows.)
> > 
> > Regards,
> > BALATON Zoltan
> 
> JFYI: I'm not sure whether that's related to this, but there was a general 
> event handling issue with Gtk3 on macOS which caused mouse events being 
> dropped:
> 
> https://gitlab.gnome.org/GNOME/gtk/-/issues/986

Hi Christian,

Thanks for the reference. I've looked at the patch and I'm not sure if
the Cocoa issues are related to GTK. It's likely something different.

After skimming over QT bug tracker I found a mathcing ticket that
confirms findings of earlier email:

  https://bugreports.qt.io/browse/QTBUG-89436

  Workaround is to build app as app bundle. Or manually deactivate and
  re-activate the app, like the JavaFX workaround does.

Regards,
Roman

> 
> According to the response, they seem to have fixed it meanwhile with a 
> different patch than suggested by me, but I haven't tested theirs.
> 
> Best regards,
> Christian Schoenebeck
> 
> 
>