[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled |
|
Date: |
Sun, 10 Jan 2021 12:16:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/10/21 9:14 AM, Bin Meng wrote:
> From: Xuzhou Cheng <xuzhou.cheng@windriver.com>
>
> When a write to ECSPI_CONREG register to disable the SPI controller,
> imx_spi_reset() is called to reset the controller, but chip select
> lines should have been disabled, otherwise the state machine of any
> devices (e.g.: SPI flashes) connected to the SPI master is stuck to
> its last state and responds incorrectly to any follow-up commands.
>
> Fixes: c906a3a01582 ("i.MX: Add the Freescale SPI Controller")
> Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - Move the chip selects disable out of imx_spi_reset()
>
> Changes in v2:
> - Fix the "Fixes" tag in the commit message
>
> hw/ssi/imx_spi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v4 1/6] hw/ssi: imx_spi: Use a macro for number of chip selects supported, (continued)
[PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled, Bin Meng, 2021/01/10
- Re: [PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled,
Philippe Mathieu-Daudé <=
[PATCH v4 4/6] hw/ssi: imx_spi: Log unimplemented burst length, Bin Meng, 2021/01/10
[PATCH v4 5/6] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic, Bin Meng, 2021/01/10
[PATCH v4 6/6] hw/ssi: imx_spi: Correct tx and rx fifo endianness, Bin Meng, 2021/01/10