[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] .github: point Repo Lockdown bot to GitLab repo
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 1/6] .github: point Repo Lockdown bot to GitLab repo |
Date: |
Tue, 12 Jan 2021 10:33:16 +0000 |
On Tue, Jan 12, 2021 at 08:49:55AM +0100, Thomas Huth wrote:
> On 11/01/2021 12.51, Daniel P. Berrangé wrote:
> > On Mon, Jan 11, 2021 at 11:50:12AM +0000, Stefan Hajnoczi wrote:
> > > Use the GitLab repo URL as the main repo location in order to reduce
> > > load on qemu.org.
> > >
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > ---
> > > .github/lockdown.yml | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/.github/lockdown.yml b/.github/lockdown.yml
> > > index 9acc393f1c..07fc2f31ee 100644
> > > --- a/.github/lockdown.yml
> > > +++ b/.github/lockdown.yml
> > > @@ -10,8 +10,8 @@ issues:
> > > comment: |
> > > Thank you for your interest in the QEMU project.
> > > - This repository is a read-only mirror of the project's master
> > > - repostories hosted on https://git.qemu.org/git/qemu.git.
> > > + This repository is a read-only mirror of the project's repostories
> > > hosted
> > > + at https://gitlab.com/qemu-project/qemu.git.
> >
> > NB this URL triggers a redirect to strip the .git suffix
> >
> > https://gitlab.com/qemu-project/qemu
>
> If you try to do:
>
> git clone https://gitlab.com/qemu-project/qemu
>
> You get this warning message instead:
>
> warning: redirecting to https://gitlab.com/qemu-project/qemu.git/
>
> So I think the patch is fine.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Same here. https://gitlab.com/qemu-project/qemu.git clones without
warnings here. https://gitlab.com/qemu-project/qemu clones with a
warning, so I think we should leave the patch unchanged.
Stefan
signature.asc
Description: PGP signature
- [PATCH 0/6] Update git repo URLs to GitLab, Stefan Hajnoczi, 2021/01/11
- [PATCH 2/6] gitmodules: use GitLab repos instead of qemu.org, Stefan Hajnoczi, 2021/01/11
- [PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command, Stefan Hajnoczi, 2021/01/11
- [PATCH 4/6] docs: update README to use GitLab repo URLs, Stefan Hajnoczi, 2021/01/11
- [PATCH 5/6] pc-bios: update mirror URLs to GitLab, Stefan Hajnoczi, 2021/01/11