qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 34/35] Auto-import Docker support files


From: Alessandro Di Federico
Subject: Re: [PATCH v6 34/35] Auto-import Docker support files
Date: Tue, 12 Jan 2021 14:53:19 +0100

On Tue, 12 Jan 2021 11:58:30 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> > -            for filename in args.extra_files or []:
> > +            extra_files = args.extra_files or []
> > +            extra_files += glob(basename + ".*")
> > +            for filename in extra_files:  
> 
> Hmm not so sure about this magic. What's wrong with the existing
> --extra-files mechanism? 

I'd be OK with using that, but how can I automate it?

It is my understanding that `--extra-files` is only set by through the
EXTRA_FILES environment variable. Therefore the user should do
something like this:

    make check-tcg \
        DOCKER_IMAGE=debian-hexagon-cross \
        DOCKER_CROSS_CC_GUEST=hexagon-unknown-linux-musl-clang \
        EXTRA_FILES="..."

Or am I missing some part of how this works?

-- 
Alessandro Di Federico
rev.ng



reply via email to

[Prev in Thread] Current Thread [Next in Thread]