Re: [PATCH v4 0/8] acpi: Some fixes for pxb support for ARM virt machine

[Igor Mammedov]

On Tue, 12 Jan 2021 05:37:29 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Looks good to me. Igor, want to ack before I apply this?

Looks good to me too, so

Acked-by: Igor Mammedov <imammedo@redhat.com>

> 
> On Tue, Jan 12, 2021 at 06:19:03PM +0800, Jiahui Cen wrote:
> > Kindly ping...
> > 
> > Thanks,
> > Jiahui
> > 
> > On 2021/1/7 19:40, Jiahui Cen wrote:  
> > > This patch series adds some fixes for ARM virt machine pxb support.
> > > 1. Pass addr offset for IO, MMIO and bus number when builing crs, because
> > > the addr_trans is needed to describe an addr resource. [1]
> > > 2. Inform guest os not to ignore the resource map generated by firmware as
> > > the x86 default way. [2]
> > > 3. Enable pxb for ARM virt machine by default.
> > > 4. Update expected DSDT files with the above changes and enable the pxb
> > > unit-test.
> > > 
> > > v3->v4:
> > > * Separate the patch of ordering root buses for further discussion. [3]
> > > 
> > > v2->v3:
> > > * Reorder the root bridges.
> > > * Exclude resources of extra root bridges from main root bridge's _CRS.
> > > 
> > > v1->v2:
> > > * Update expected DSDT files.
> > > * Quote PCI Firmware spec as comments.
> > > 
> > > [1]: 
> > > https://lore.kernel.org/qemu-devel/20201217132747.4744-1-cenjiahui@huawei.com/
> > > [2]: 
> > > https://lore.kernel.org/qemu-devel/20201217132926.4812-1-cenjiahui@huawei.com/
> > > [3]: 
> > > dca69f55-dfd1-3f97-dc3f-13eeedec5027@huawei.com/">https://lore.kernel.org/qemu-devel/dca69f55-dfd1-3f97-dc3f-13eeedec5027@huawei.com/
> > > 
> > > Jiahui Cen (8):
> > >   acpi: Allow DSDT acpi table changes
> > >   acpi: Fix unmatched expected DSDT.pxb file
> > >   acpi: Add addr offset in build_crs
> > >   acpi/gpex: Inform os to keep firmware resource map
> > >   acpi/gpex: Exclude pxb's resources from PCI0
> > >   Kconfig: Compile PXB for ARM_VIRT
> > >   acpi: Enable pxb unit-test for ARM virt machine
> > >   acpi: Update _DSM method in expected files
> > > 
> > >  hw/acpi/aml-build.c               |  18 ++--
> > >  hw/i386/acpi-build.c              |   3 +-
> > >  hw/pci-bridge/Kconfig             |   2 +-
> > >  hw/pci-host/gpex-acpi.c           |  87 ++++++++++++++------
> > >  include/hw/acpi/aml-build.h       |   4 +-
> > >  tests/data/acpi/microvm/DSDT.pcie | Bin 3023 -> 3031 bytes
> > >  tests/data/acpi/virt/DSDT         | Bin 5196 -> 5204 bytes
> > >  tests/data/acpi/virt/DSDT.memhp   | Bin 6557 -> 6565 bytes
> > >  tests/data/acpi/virt/DSDT.numamem | Bin 5196 -> 5204 bytes
> > >  tests/data/acpi/virt/DSDT.pxb     | Bin 7802 -> 7689 bytes
> > >  tests/qtest/bios-tables-test.c    |   4 -
> > >  11 files changed, 79 insertions(+), 39 deletions(-)
> > >   
> 
>