[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_so
From: |
Markus Armbruster |
Subject: |
[PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test |
Date: |
Wed, 13 Jan 2021 10:31:01 +0100 |
From: Lukas Straub <lukasstraub2@web.de>
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_instance will abort, because the yank instance is
already/still registered.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id:
<1445e97a5800e3f2ba024ad52b500a0315701632.1609167865.git.lukasstraub2@web.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/test-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index 06102977b6..469d25989c 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer
opaque)
g_assert_nonnull(opts);
chr1 = qemu_chr_new_from_opts(opts, NULL, &error_abort);
g_assert_nonnull(chr1);
+ qemu_chr_wait_connected(chr1, &error_abort);
chr2 = qemu_chr_new_from_opts(opts, NULL, &local_err);
g_assert_null(chr2);
--
2.26.2
- [PULL 0/7] Yank patches patches for 2021-01-13, Markus Armbruster, 2021/01/13
- [PULL 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown, Markus Armbruster, 2021/01/13
- [PULL 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe, Markus Armbruster, 2021/01/13
- [PULL 4/7] migration: Add yank feature, Markus Armbruster, 2021/01/13
- [PULL 2/7] block/nbd.c: Add yank feature, Markus Armbruster, 2021/01/13
- [PULL 1/7] Introduce yank feature, Markus Armbruster, 2021/01/13
- [PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test,
Markus Armbruster <=
- [PULL 3/7] chardev/char-socket.c: Add yank feature, Markus Armbruster, 2021/01/13
- Re: [PULL 0/7] Yank patches patches for 2021-01-13, Peter Maydell, 2021/01/13
- Re: [PULL 0/7] Yank patches patches for 2021-01-13, Markus Armbruster, 2021/01/13
- Re: [PULL 0/7] Yank patches patches for 2021-01-13, Alex Bennée, 2021/01/14
- [PATCH] Fix build with new yank feature by adding stubs, Lukas Straub, 2021/01/14
- Re: [PATCH] Fix build with new yank feature by adding stubs, Alex Bennée, 2021/01/14
- Re: [PATCH] Fix build with new yank feature by adding stubs, Philippe Mathieu-Daudé, 2021/01/14