[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/11] hw/m68k/next-cube: Add missing header comment to next-
From: |
Thomas Huth |
Subject: |
Re: [PATCH 11/11] hw/m68k/next-cube: Add missing header comment to next-cube.h |
Date: |
Sat, 16 Jan 2021 08:36:36 +0100 |
Am Fri, 15 Jan 2021 20:12:06 +0000
schrieb Peter Maydell <peter.maydell@linaro.org>:
> The next-cube.h file is missing the usual copyright-and-license
> header; add it (same as the next-cube.c one).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/m68k/next-cube.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/hw/m68k/next-cube.h b/include/hw/m68k/next-cube.h
> index d38c52d540d..43577282d15 100644
> --- a/include/hw/m68k/next-cube.h
> +++ b/include/hw/m68k/next-cube.h
> @@ -1,3 +1,13 @@
> +/*
> + * NeXT Cube
> + *
> + * Copyright (c) 2011 Bryce Lanham
> + *
> + * This code is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published
> + * by the Free Software Foundation; either version 2 of the License,
> + * or (at your option) any later version.
> + */
>
> #ifndef NEXT_CUBE_H
> #define NEXT_CUBE_H
The file is based on Bryce's original version, indeed:
https://github.com/blanham/qemu-NeXT/blob/next-cube/hw/next-cube.h
So I think that header comment is appropriate.
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
- Re: [PATCH 06/11] hw/m68k/next-cube: Move int_status and int_mask to NeXTPC struct, (continued)
- [PATCH 07/11] hw/m68k/next-cube: Make next_irq GPIO inputs to NEXT_PC device, Peter Maydell, 2021/01/15
- [PATCH 09/11] hw/m68k/next-cube: Remove unused fields from NeXTState, Peter Maydell, 2021/01/15
- [PATCH 08/11] hw/m68k/next-cube: Move rtc into NeXTPC struct, Peter Maydell, 2021/01/15
- [PATCH 10/11] hw/m68k/next-cube: Add vmstate for NeXTPC device, Peter Maydell, 2021/01/15
- [PATCH 11/11] hw/m68k/next-cube: Add missing header comment to next-cube.h, Peter Maydell, 2021/01/15
- Re: [PATCH 11/11] hw/m68k/next-cube: Add missing header comment to next-cube.h,
Thomas Huth <=