Re: [PATCH v2] ide: atapi: check logical block address and read size (CVE-2020-29443)

[no-reply]

Patchew URL: 
20210118063229.442350-1-ppandit@redhat.com/">https://patchew.org/QEMU/20210118063229.442350-1-ppandit@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210118063229.442350-1-ppandit@redhat.com
Subject: [PATCH v2] ide: atapi: check logical block address and read size 
(CVE-2020-29443)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210118063229.442350-1-ppandit@redhat.com -> 
patchew/20210118063229.442350-1-ppandit@redhat.com
Switched to a new branch 'test'
8f56049 ide: atapi: check logical block address and read size (CVE-2020-29443)

=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#25: FILE: hw/ide/atapi.c:325:
+    assert (0 <= lba && lba < (s->nb_sectors >> 2));

ERROR: space prohibited between function name and open parenthesis '('
#34: FILE: hw/ide/atapi.c:425:
+    assert (0 <= lba && lba < (s->nb_sectors >> 2));

total: 2 errors, 0 warnings, 71 lines checked

Commit 8f560492c204 (ide: atapi: check logical block address and read size 
(CVE-2020-29443)) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210118063229.442350-1-ppandit@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210118063229.442350-1-ppandit@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com