[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/11] hw/m68k/next-cube: Move scr_ops into NeXTPC device
From: |
Thomas Huth |
Subject: |
[PULL 04/11] hw/m68k/next-cube: Move scr_ops into NeXTPC device |
Date: |
Tue, 19 Jan 2021 09:36:10 +0100 |
From: Peter Maydell <peter.maydell@linaro.org>
Move the registers handled by the scr_ops struct into the NeXTPC
device.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210115201206.17347-5-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
hw/m68k/next-cube.c | 50 ++++++++++++++++++++++-----------------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index 17a020e2a0..7d44bcf783 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -76,8 +76,6 @@ struct NeXTState {
uint32_t int_mask;
uint32_t int_status;
- uint8_t scsi_csr_1;
- uint8_t scsi_csr_2;
next_dma dma[10];
qemu_irq *scsi_irq;
qemu_irq scsi_dma;
@@ -98,9 +96,12 @@ struct NeXTPC {
NeXTState *ns;
MemoryRegion mmiomem;
+ MemoryRegion scrmem;
uint32_t scr1;
uint32_t scr2;
+ uint8_t scsi_csr_1;
+ uint8_t scsi_csr_2;
};
/* Thanks to NeXT forums for this */
@@ -403,7 +404,7 @@ static const MemoryRegionOps mmio_ops = {
.endianness = DEVICE_NATIVE_ENDIAN,
};
-static uint32_t scr_readb(NeXTState *s, hwaddr addr)
+static uint32_t scr_readb(NeXTPC *s, hwaddr addr)
{
switch (addr) {
case 0x14108:
@@ -437,13 +438,13 @@ static uint32_t scr_readb(NeXTState *s, hwaddr addr)
}
}
-static uint32_t scr_readw(NeXTState *s, hwaddr addr)
+static uint32_t scr_readw(NeXTPC *s, hwaddr addr)
{
DPRINTF("BMAP Read W @ %x\n", (unsigned int)addr);
return 0;
}
-static uint32_t scr_readl(NeXTState *s, hwaddr addr)
+static uint32_t scr_readl(NeXTPC *s, hwaddr addr)
{
DPRINTF("BMAP Read L @ %x\n", (unsigned int)addr);
return 0;
@@ -456,7 +457,7 @@ static uint32_t scr_readl(NeXTState *s, hwaddr addr)
#define SCSICSR_CPUDMA 0x10 /* if set, dma enabled */
#define SCSICSR_INTMASK 0x20 /* if set, interrupt enabled */
-static void scr_writeb(NeXTState *s, hwaddr addr, uint32_t value)
+static void scr_writeb(NeXTPC *s, hwaddr addr, uint32_t value)
{
switch (addr) {
case 0x14108:
@@ -502,9 +503,9 @@ static void scr_writeb(NeXTState *s, hwaddr addr, uint32_t
value)
DPRINTF("SCSICSR CPUDMA\n");
/* qemu_irq_raise(s->scsi_dma); */
- s->int_status |= 0x4000000;
+ s->ns->int_status |= 0x4000000;
} else {
- s->int_status &= ~(0x4000000);
+ s->ns->int_status &= ~(0x4000000);
}
if (value & SCSICSR_INTMASK) {
DPRINTF("SCSICSR INTMASK\n");
@@ -534,27 +535,27 @@ static void scr_writeb(NeXTState *s, hwaddr addr,
uint32_t value)
}
}
-static void scr_writew(NeXTState *s, hwaddr addr, uint32_t value)
+static void scr_writew(NeXTPC *s, hwaddr addr, uint32_t value)
{
DPRINTF("BMAP Write W @ %x with %x\n", (unsigned int)addr, value);
}
-static void scr_writel(NeXTState *s, hwaddr addr, uint32_t value)
+static void scr_writel(NeXTPC *s, hwaddr addr, uint32_t value)
{
DPRINTF("BMAP Write L @ %x with %x\n", (unsigned int)addr, value);
}
static uint64_t scr_readfn(void *opaque, hwaddr addr, unsigned size)
{
- NeXTState *ns = NEXT_MACHINE(opaque);
+ NeXTPC *s = NEXT_PC(opaque);
switch (size) {
case 1:
- return scr_readb(ns, addr);
+ return scr_readb(s, addr);
case 2:
- return scr_readw(ns, addr);
+ return scr_readw(s, addr);
case 4:
- return scr_readl(ns, addr);
+ return scr_readl(s, addr);
default:
g_assert_not_reached();
}
@@ -563,17 +564,17 @@ static uint64_t scr_readfn(void *opaque, hwaddr addr,
unsigned size)
static void scr_writefn(void *opaque, hwaddr addr, uint64_t value,
unsigned size)
{
- NeXTState *ns = NEXT_MACHINE(opaque);
+ NeXTPC *s = NEXT_PC(opaque);
switch (size) {
case 1:
- scr_writeb(ns, addr, value);
+ scr_writeb(s, addr, value);
break;
case 2:
- scr_writew(ns, addr, value);
+ scr_writew(s, addr, value);
break;
case 4:
- scr_writel(ns, addr, value);
+ scr_writel(s, addr, value);
break;
default:
g_assert_not_reached();
@@ -887,8 +888,10 @@ static void next_pc_realize(DeviceState *dev, Error **errp)
memory_region_init_io(&s->mmiomem, OBJECT(s), &mmio_ops, s,
"next.mmio", 0xD0000);
-
+ memory_region_init_io(&s->scrmem, OBJECT(s), &scr_ops, s,
+ "next.scr", 0x20000);
sysbus_init_mmio(sbd, &s->mmiomem);
+ sysbus_init_mmio(sbd, &s->scrmem);
}
static void next_pc_class_init(ObjectClass *klass, void *data)
@@ -913,7 +916,6 @@ static void next_cube_init(MachineState *machine)
M68kCPU *cpu;
CPUM68KState *env;
MemoryRegion *rom = g_new(MemoryRegion, 1);
- MemoryRegion *scrmem = g_new(MemoryRegion, 1);
MemoryRegion *dmamem = g_new(MemoryRegion, 1);
MemoryRegion *bmapm1 = g_new(MemoryRegion, 1);
MemoryRegion *bmapm2 = g_new(MemoryRegion, 1);
@@ -957,6 +959,9 @@ static void next_cube_init(MachineState *machine)
/* MMIO */
sysbus_mmio_map(SYS_BUS_DEVICE(pcdev), 0, 0x02000000);
+ /* BMAP IO - acts as a catch-all for now */
+ sysbus_mmio_map(SYS_BUS_DEVICE(pcdev), 1, 0x02100000);
+
/* BMAP memory */
memory_region_init_ram_shared_nomigrate(bmapm1, NULL, "next.bmapmem", 64,
true, &error_fatal);
@@ -965,11 +970,6 @@ static void next_cube_init(MachineState *machine)
memory_region_init_alias(bmapm2, NULL, "next.bmapmem2", bmapm1, 0x0, 64);
memory_region_add_subregion(sysmem, 0x820c0000, bmapm2);
- /* BMAP IO - acts as a catch-all for now */
- memory_region_init_io(scrmem, NULL, &scr_ops, machine, "next.scr",
- 0x20000);
- memory_region_add_subregion(sysmem, 0x02100000, scrmem);
-
/* KBD */
dev = qdev_new(TYPE_NEXTKBD);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
--
2.29.2
- [PULL 00/11] m68k next-cube patches, Thomas Huth, 2021/01/19
- [PULL 01/11] hw/m68k/next-cube: Make next_irq() function static, Thomas Huth, 2021/01/19
- [PULL 02/11] hw/m68k/next-cube: Move register/interrupt functionality into a device, Thomas Huth, 2021/01/19
- [PULL 03/11] hw/m68k/next-cube: Move mmio_ops into NeXTPC device, Thomas Huth, 2021/01/19
- [PULL 05/11] hw/m68k/next-cube: Make next_irq take NeXTPC* as its opaque, Thomas Huth, 2021/01/19
- [PULL 10/11] hw/m68k/next-cube: Add vmstate for NeXTPC device, Thomas Huth, 2021/01/19
- [PULL 04/11] hw/m68k/next-cube: Move scr_ops into NeXTPC device,
Thomas Huth <=
- [PULL 11/11] hw/m68k/next-cube: Add missing header comment to next-cube.h, Thomas Huth, 2021/01/19
- [PULL 06/11] hw/m68k/next-cube: Move int_status and int_mask to NeXTPC struct, Thomas Huth, 2021/01/19
- [PULL 07/11] hw/m68k/next-cube: Make next_irq GPIO inputs to NEXT_PC device, Thomas Huth, 2021/01/19
- [PULL 08/11] hw/m68k/next-cube: Move rtc into NeXTPC struct, Thomas Huth, 2021/01/19
- [PULL 09/11] hw/m68k/next-cube: Remove unused fields from NeXTState, Thomas Huth, 2021/01/19
- Re: [PULL 00/11] m68k next-cube patches, Peter Maydell, 2021/01/19