[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] usb: add pcap support.
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH] usb: add pcap support. |
|
Date: |
Wed, 20 Jan 2021 10:13:25 +0100 |
Hi,
> > diff --git a/hw/usb/pcap.c b/hw/usb/pcap.c
> > new file mode 100644
> > index 000000000000..d3162d65e5fe
> > --- /dev/null
> > +++ b/hw/usb/pcap.c
> > @@ -0,0 +1,242 @@
>
> Missing license.
Good point.
> > +struct pcap_hdr {
>
> QEMU_PACKED?
>
> > +struct pcaprec_hdr {
>
> QEMU_PACKED?
>
> > +struct usbmon_packet {
>
> QEMU_PACKED?
Doesn't hurt, but also doesn't make a difference.
The structs are carefully layout-ed to have all
fields properly aligned.
take care,
Gerd