[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/14] tests/check-block.sh: Refuse to run the iotests with BusyBo
From: |
Thomas Huth |
Subject: |
[PULL 09/14] tests/check-block.sh: Refuse to run the iotests with BusyBox' sed |
Date: |
Wed, 20 Jan 2021 16:17:46 +0100 |
BusyBox' sed reports itself as "This is not GNU sed version 4.0"
when being run with the --version parameter. However, the iotests
really need GNU sed, they do not work with the BusyBox version.
So let's make sure that we really have GNU sed and refuse to run
the tests with BusyBox' sed.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210119134749.401311-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/check-block.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index fb4c1baae9..e4f37905be 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -60,6 +60,13 @@ if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then
echo "GNU sed not available ==> Not running the qemu-iotests."
exit 0
fi
+else
+ # Double-check that we're not using BusyBox' sed which says
+ # that "This is not GNU sed version 4.0" ...
+ if sed --version | grep -q 'not GNU sed' ; then
+ echo "BusyBox sed not supported ==> Not running the qemu-iotests."
+ exit 0
+ fi
fi
cd tests/qemu-iotests
--
2.27.0
- [PULL 00/14] gitlab-CI, qtests and misc patches, Thomas Huth, 2021/01/20
- [PULL 06/14] tests: Rename PAGE_SIZE definitions, Thomas Huth, 2021/01/20
- [PULL 07/14] accel/kvm: avoid using predefined PAGE_SIZE, Thomas Huth, 2021/01/20
- [PULL 09/14] tests/check-block.sh: Refuse to run the iotests with BusyBox' sed,
Thomas Huth <=
- [PULL 01/14] osdep.h: Remove <sys/signal.h> include, Thomas Huth, 2021/01/20
- [PULL 03/14] libvhost-user: Include poll.h instead of sys/poll.h, Thomas Huth, 2021/01/20
- [PULL 02/14] configure: Add sys/timex.h to probe clock_adjtime, Thomas Huth, 2021/01/20
- [PULL 08/14] tests/docker: Add dockerfile for Alpine Linux, Thomas Huth, 2021/01/20
- [PULL 13/14] MAINTAINERS: Remove Ben Warren, Thomas Huth, 2021/01/20
- [PULL 04/14] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE, Thomas Huth, 2021/01/20
- [PULL 05/14] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE, Thomas Huth, 2021/01/20
- [PULL 10/14] gitlab-ci: Add alpine to pipeline, Thomas Huth, 2021/01/20
- [PULL 14/14] MAINTAINERS: Make status spellings consistent, Thomas Huth, 2021/01/20
- [PULL 11/14] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get, Thomas Huth, 2021/01/20