[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] configure: Emit warning when accelerator requested but n
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 3/3] configure: Emit warning when accelerator requested but not needed |
|
Date: |
Wed, 20 Jan 2021 18:00:28 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/20/21 5:33 PM, Thomas Huth wrote:
> On 20/01/2021 16.19, Philippe Mathieu-Daudé wrote:
>> In some configurations it might be pointless to check and
>> compile accelerator code. Do not deselect the accelerator,
>> but emit a warning.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> configure | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/configure b/configure
>> index a5159157a49..09e1cd8bfe6 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5514,6 +5514,27 @@ if test $git_update = 'yes' ; then
>> (cd "${source_path}" && GIT="$git" "./scripts/git-submodule.sh"
>> update "$git_submodules")
>> fi
>> +if [ "$softmmu" = "no" ]; then
>> + if [ "$tcg" = "enabled" ]; then
>> + echo "WARN: TCG accelerator selected but no target requires it"
>> + fi
>
> What about linux-user? It needs TCG, but it can also be compiled with
> softmmu disabled, can't it?
Indeed, thanks for reviewing.