[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax
From: |
Eduardo Habkost |
Subject: |
[PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax |
Date: |
Wed, 20 Jan 2021 15:12:41 -0500 |
The ordering semantics of +feature/-feature is tricky and not
obvious, and it requires a custom option parser. Deprecate that
syntax so we can eventually remove the custom -cpu option parser
and plus_features/minus_features global variables in i386.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
docs/system/deprecated.rst | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index e20bfcb17a4..2c4b8d4b78b 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -127,6 +127,20 @@ Drives with interface types other than ``if=none`` are for
onboard
devices. It is possible to use drives the board doesn't pick up with
-device. This usage is now deprecated. Use ``if=none`` instead.
+``-cpu`` ``+feature`` and ``-feature`` syntax (since 6.0.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+The ``-cpu ...,+feature`` and ``-cpu ...,-feature`` syntax for
+enabling and disabling CPU features is deprecated. The ``-cpu
+...,feature=on`` or ``-cpu ...,feature=off`` should be used
+instead.
+
+Note that the ordering semantics of ``-cpu ...,-feature,+feature``
+is different from ``-cpu ...,feature=off,feature=on``. With the
+former, the feature got disabled because ``-feature`` had
+precedence, but with the latter the feature will be enabled
+because options are applied in the order they appear.
+
QEMU Machine Protocol (QMP) commands
------------------------------------
--
2.28.0
- [RFC PATCH 1/2] hw/i386: -cpu model, -feature, +feature should enable feature, (continued)
- [RFC PATCH 1/2] hw/i386: -cpu model, -feature, +feature should enable feature, David Edmondson, 2021/01/19
- Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Eduardo Habkost, 2021/01/19
- Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, David Edmondson, 2021/01/19
- Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Eduardo Habkost, 2021/01/19
- Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Igor Mammedov, 2021/01/20
- Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, David Edmondson, 2021/01/20
- Re: [External] : Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Daniel P . Berrangé, 2021/01/20
- Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, David Edmondson, 2021/01/20
- Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Eduardo Habkost, 2021/01/20
- Re: [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature should enable feature, Igor Mammedov, 2021/01/20
- [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax,
Eduardo Habkost <=
- Re: [PATCH] docs/system: Deprecate `-cpu ..., +feature, -feature` syntax, David Edmondson, 2021/01/20
- Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax, Daniel P . Berrangé, 2021/01/21
- Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax, John Snow, 2021/01/26
- Re: [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax, Igor Mammedov, 2021/01/21
Re: [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults, Daniel P . Berrangé, 2021/01/19