[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] meson: Display cryto-related information altogether
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 7/8] meson: Display cryto-related information altogether |
Date: |
Thu, 21 Jan 2021 12:01:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/21/21 11:13 AM, Daniel P. Berrangé wrote:
> On Thu, Jan 21, 2021 at 10:11:32AM +0000, Daniel P. Berrangé wrote:
>> On Thu, Jan 21, 2021 at 10:56:15AM +0100, Philippe Mathieu-Daudé wrote:
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>> Cc: Daniel P. Berrange <berrange@redhat.com>
>>> ---
>>> meson.build | 34 +++++++++++++++++++---------------
>>> 1 file changed, 19 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/meson.build b/meson.build
>>> index e372b69f163..9274775a81a 100644
>>> --- a/meson.build
>>> +++ b/meson.build
>>> @@ -2453,19 +2453,8 @@
>>> endif
>>> summary(summary_info, bool_yn: true, section: 'Block layer support')
>>>
>>> +# Crypto
>>
>> Rather than a comment why not introduce grouping in the output
>> so it is visible when reading the summary.
>>
>> This can be done in meson by calling summary() multiple times
>> giving "section: 'Crypto'" arg.
>
> Sigh, I'm not very good at reading this morning. I see this
> is in fact done in this patch, I just couldn't see it in the
> diff :-(
No worry, I should have describe this better in the commit
description.
> ...
>>> +summary(summary_info, bool_yn: true, section: 'Crypto')
>
>
> Regards,
> Daniel
>
- [PATCH v2 1/8] meson: Summarize information related to directories first, (continued)
- [PATCH v2 1/8] meson: Summarize information related to directories first, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 2/8] meson: Display host binaries information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 3/8] meson: Summarize overall features altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 4/8] meson: Summarize compilation-related information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [RFC PATCH v2 6/8] meson: Display block layer information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 5/8] meson: Display accelerators and selected targets altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 7/8] meson: Display cryto-related information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 8/8] meson: Display library dependencies altogether, Philippe Mathieu-Daudé, 2021/01/21
- Re: [PATCH v2 0/8] meson: Clarify summary, Paolo Bonzini, 2021/01/21