Re: [PATCH] gitlab-ci: Test building linux-user targets on CentOS 7

[Philippe Mathieu-Daudé]

On Thu, Jan 21, 2021 at 3:01 PM Thomas Huth <thuth@redhat.com> wrote:
> On 21/01/2021 14.14, Philippe Mathieu-Daudé wrote:
> >> +build-user-centos7:
> >> +  <<: *native_build_job_definition
> >> +  variables:
> >> +    IMAGE: centos7
> >> +    CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs
> >> +    MAKE_CHECK_ARGS: check-tcg
>
> Ok ... just be aware of the fact that we might remove it again in some few
> months, since we then won't support CentOS 7 anymore (RHEL8 has been
> released in May 2019 and according to our support policy we will drop
> support for the previous version two years later, i.e. in May 2021).

I'm not against it, as long as our CI catches the same errors found by
Peter testing
(I suppose Peter will stop testing on his particular machine by May 2021, else
there is another CI gap).

> > check-tcg calls build-tcg which fails:
> >
> >    BUILD   TCG tests for x86_64-softmmu
> >    BUILD   x86_64-softmmu guest-tests with cc
> > /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
> > /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
> >    BUILD   TCG tests for x86_64-linux-user
> >    BUILD   x86_64-linux-user guest-tests with cc
> > /usr/bin/ld: cannot find -lpthread
> > /usr/bin/ld: cannot find -lc
> > collect2: error: ld returned 1 exit status
> > make[2]: *** [threadcount] Error 1
> > make[1]: *** [cross-build-guest-tests] Error 2
> > make: *** [build-tcg-tests-x86_64-linux-user] Error 2
> >
> > Apparently this is due to the -static flag:
> >
> > $ gcc  -Wall -Werror -O0 -g -fno-strict-aliasing -m64
> > tests/tcg/multiarch/threadcount.c -o threadcount  -static -lpthread
> > /usr/bin/ld: cannot find -lpthread
> > /usr/bin/ld: cannot find -lc
> > collect2: error: ld returned 1 exit status
> >
> > Do we need to install these packages?
> >
> > glibc-static.i686 : C library static libraries for -static linking.
> > glibc-static.x86_64 : C library static libraries for -static linking.
> >
> > Or simply ignore testing?
>
> If testing then succeeds, I think I'd prefer to add the package to the
> docker file.

Yes, tests run fine. Sent a v2.