Re: [PATCH 0/2] Add ipv6 hostfwd support

[Doug Evans]

On Thu, Jan 21, 2021 at 1:41 AM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

Hi Doug,

On Thu, Jan 21, 2021 at 12:24 PM dje--- via <qemu-devel@nongnu.org> wrote:
>
> Hi. This patchset takes the original patch from Maxim,
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
> and updates it.
>
> The first patch is the slirp additions, the second patch adds the u/i.

libslirp is maintained on gitlab. Can you open a merge request?
https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests

thanks

Hi. Sure, no problem.

I wasn't sure what the procedure is but figured it would come out during the review.

How does review of libslirp patches work?

I gather Samuel is a libslirp maintainer so I'm guessing it just needs to be approved here (after appropriate review) and then afterwards I should file the merge request?

 

>
> Doug Evans (2):
>   slirp: Add ipv6 hostfwd support
>   net: Add ipv6_hostfwd option
>
> Slirp:
>  src/libslirp.h |   6 +++
>  src/slirp.c    |  51 +++++++++++++++++++++--
>  src/socket.c   | 109 +++++++++++++++++++++++++++++++++++--------------
>  src/socket.h   |   9 ++++
>  src/udp.c      |  73 ++++++++++++++++++++++++++-------
>  src/udp.h      |   2 +
>  6 files changed, 202 insertions(+), 48 deletions(-)
>
> QEMU:
>  hmp-commands.hx     |  29 ++++-
>  include/net/slirp.h |   2 +
>  net/slirp.c         | 311 +++++++++++++++++++++++++++++++++++---------
>  qapi/net.json       |   1 +
>  slirp               |   2 +-
>  5 files changed, 279 insertions(+), 66 deletions(-)
>
> --
> 2.30.0.296.g2bfb1c46d8-goog
>
>


--
Marc-André Lureau