[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request
From: |
Gerd Hoffmann |
Subject: |
Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request |
Date: |
Fri, 22 Jan 2021 14:42:13 +0100 |
On Fri, Jan 22, 2021 at 01:49:38PM +0100, Laszlo Ersek wrote:
> On 01/22/21 09:46, Gerd Hoffmann wrote:
> >> This patch breaks QEMU for me.
> >
> >> The symptom is the following: in virt-manager, the display remains dead
> >> (black), when I start an OVMF guest. At the same time, unusually high
> >> CPU load can be seen on the host; it makes me think that virt-manager is
> >> trying, in a busy loop, to complete the VNC handshake, or some such.
> >> Ultimately, although the guest boots up fine, virt-manager gives up, and
> >> the display window says "Viewer was disconnected".
> >
> > It is the vnc_colordepth() call. Seems gtk-vnc sends a update request
> > with incremental=0 as response to the VNC_ENCODING_WMVi message. So
> > sending that as response to an incremental=0 update request creates an
> > endless loop ...
>
> Interesting; I saw that commit 9e1632ad07ca *added* (as opposed to
> *moving*) the vnc_colordepth() call; I thought it was a relatively
> insignificant bit...
/me too.
Some discussions in the resize changes indicated that the idea of a
non-incremetal update request is that the server sends the *full*
server-side state, so the client can render the screen properly without
remembering old state.
So I thought ok, lets send the colordepth info too, no big deal ...
take care,
Gerd
- [PULL 00/11] Ui 20210115 patches, Gerd Hoffmann, 2021/01/15
- [PULL 02/11] ui/gtk: rename variable window to widget, Gerd Hoffmann, 2021/01/15
- [PULL 01/11] ui/gtk: don't try to redefine SI prefixes, Gerd Hoffmann, 2021/01/15
- [PULL 03/11] ui/gtk: limit virtual console max update interval, Gerd Hoffmann, 2021/01/15
- [PULL 04/11] ui/gtk: expose gd_monitor_update_interval, Gerd Hoffmann, 2021/01/15
- [PULL 10/11] vnc: move initialization to framebuffer_update_request, Gerd Hoffmann, 2021/01/15
[PULL 07/11] ui: add support for remote power control to VNC server, Gerd Hoffmann, 2021/01/15
[PULL 08/11] vnc: Fix a memleak in vnc_display_connect(), Gerd Hoffmann, 2021/01/15
[PULL 05/11] ui/gtk: update monitor interval on egl displays, Gerd Hoffmann, 2021/01/15
[PULL 11/11] vnc: add support for extended desktop resize, Gerd Hoffmann, 2021/01/15
[PULL 06/11] vnc: fix unfinalized tlscreds for VncDisplay, Gerd Hoffmann, 2021/01/15
[PULL 09/11] vnc: move check into vnc_cursor_define, Gerd Hoffmann, 2021/01/15
Re: [PULL 00/11] Ui 20210115 patches, Peter Maydell, 2021/01/15