[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry' |
|
Date: |
Fri, 22 Jan 2021 14:45:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/22/21 2:37 PM, Philippe Mathieu-Daudé wrote:
> On 1/22/21 1:24 PM, Bin Meng wrote:
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> There is already a MemMapEntry type defined in hwaddr.h. Let's drop
>> the loongson3 defined `struct MemmapEntry` and use the existing one.
>
> Not really... based on 0e324626306:
>
> $ git grep MemmapEntry origin/master -- include
> $
OK I understood, you replaced MemmapEntry by MemMapEntry which
is written slightly differently.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thanks!