[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing |
|
Date: |
Fri, 22 Jan 2021 12:10:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/22/21 11:58 AM, Philippe Mathieu-Daudé wrote:
>> +#include "qemu/osdep.h"
>> +#include "insn.h"
>> +
>> +extern void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,
>> + target_ulong pc);
>> +extern void snprint_a_pkt_debug(GString *buf, Packet *pkt);
>
> No need to declare prototypes in header with 'extern'...
> (also noticed in other patches).
Using the extern on function declarations is not wrong (in fact, some
projects prefer to use extern for everything in a header, regardless of
whether it is function or data, rather than just limiting it to data).
But you do have a point that it's not common practice in qemu, and local
consistency is better than any habits you've picked up in other projects.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v7 34/35] Hexagon build infrastructure, (continued)
- [PATCH v7 05/35] Hexagon (disas) disassembler, Taylor Simpson, 2021/01/19
- [PATCH v7 35/35] Add Dockerfile for hexagon, Taylor Simpson, 2021/01/19
- [PATCH v7 08/35] Hexagon (target/hexagon) GDB Stub, Taylor Simpson, 2021/01/19
- [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing, Taylor Simpson, 2021/01/19
- [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions, Taylor Simpson, 2021/01/19
[PATCH v7 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics, Taylor Simpson, 2021/01/19
[PATCH v7 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2021/01/19
[PATCH v7 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions, Taylor Simpson, 2021/01/19
[PATCH v7 18/35] Hexagon (target/hexagon/imported) arch import, Taylor Simpson, 2021/01/19
[PATCH v7 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files, Taylor Simpson, 2021/01/19