[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tcg: Restart code generation when we run out of temps
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] tcg: Restart code generation when we run out of temps |
|
Date: |
Sun, 24 Jan 2021 01:27:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/24/21 12:01 AM, Richard Henderson wrote:
> Some large translation blocks can generate so many unique
> constants that we run out of temps to hold them. In this
> case, longjmp back to the start of code generation and
> restart with a smaller translation block.
Clever and way nicer.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Buglink: https://bugs.launchpad.net/bugs/1912065
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> This replaces both the patch to increase the number of temps,
> and the buggy patch set that dynamically allocated the temps.
>
>
> r~
>
> ---
> include/tcg/tcg.h | 3 +++
> accel/tcg/translate-all.c | 15 ++++++++++++++-
> tcg/tcg.c | 11 ++++++++---
> 3 files changed, 25 insertions(+), 4 deletions(-)