|
| From: | Markus Armbruster |
| Subject: | Re: [PATCH 10/25] hmp: special case help options for object_add |
| Date: | Mon, 25 Jan 2021 15:02:35 +0100 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 25/01/21 13:48, Markus Armbruster wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Fix "object_add help" and "object_add TYPE,help".
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Standard question when I read "Fix $interface" in a commit message:
>> how
>> exactly is it broken?
>
> It doesn't work at all ("Error: parameter 'id' is missing").
Adding simple reproducers to commit messages won't hurt a bit, I
promise!
;-P
| [Prev in Thread] | Current Thread | [Next in Thread] |