qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/12] meson: Restrict emulation code


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 08/12] meson: Restrict emulation code
Date: Mon, 25 Jan 2021 16:09:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/22/21 9:44 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Richard Henderson <richard.henderson@linaro.org>
> ---
>  meson.build | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 396ea3aa19b..b5afa2923b3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1809,16 +1809,18 @@
>  qemuutil = declare_dependency(link_with: libqemuutil,
>                                sources: genh + version_res)
>  
> -decodetree = generator(find_program('scripts/decodetree.py'),
> -                       output: 'decode-@BASENAME@.c.inc',
> -                       arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o', 
> '@OUTPUT@'])
> +if have_system or have_user

Maybe better as:

   if not get_option('tcg').disabled()

And even clearer as:

   if get_option('tcg').enabled()

assuming enabled would be "auto" or "yes".

> +  decodetree = generator(find_program('scripts/decodetree.py'),
> +                         output: 'decode-@BASENAME@.c.inc',
> +                         arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o', 
> '@OUTPUT@'])
> +  subdir('libdecnumber')
> +  subdir('target')
> +endif
>  
>  subdir('audio')
>  subdir('io')
>  subdir('chardev')
>  subdir('fsdev')
> -subdir('libdecnumber')
> -subdir('target')
>  subdir('dump')
>  
>  block_ss.add(files(
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]