Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

[Stefan Hajnoczi]

On Mon, Jan 25, 2021 at 08:50:23PM +0100, BALATON Zoltan wrote:
> On Mon, 25 Jan 2021, Stefan Hajnoczi wrote:
> > Zoltan reminded me that the 'log' backend prints tids/timestamps and this 
> > can
> > be unwanted in some cases. It's easier to look at trace output without them 
> > and
> > in some cases parsing is also more convenient with them.
> > 
> > Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp 
> > output.
> 
> Thank you, this works for me
> 
> Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
> 
> but I had to remove build dir and rerun configure to get it omit timestamps.
> Just running make (which reruns configure) or make distclean and running
> configure does not seem to be enough to pick up some changes since the meson
> conversion. (I had similar problem with gtk being detected and used despite
> having --disable-gtk on configure before the gtk test was moved to meson; so
> I think there's some problem detecting changes in configure options
> somewhere. That was also fixed by rerunning configure after starting from
> clean build dir but did not work when keeping old build dir or make
> distclean. This is probably not a problem for someone downloading the
> sources and compiling it once, only annoying for developers who build it all
> the time.)

Thanks! The following meson.build fix in the tracing queue:

  [PATCH] trace: add meson custom_target() depend_files for tracetool

It solves this issue.

Stefan

signature.asc
Description: PGP signature