qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64


From: Richard Henderson
Subject: Re: [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64
Date: Wed, 27 Jan 2021 12:55:56 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 1/27/21 11:07 AM, Stefan Weil wrote:
>          case INDEX_op_ld8s_i64:
> -            TODO();
> +            t0 = *tb_ptr++;
> +            t1 = tci_read_r(regs, &tb_ptr);
> +            t2 = tci_read_s32(&tb_ptr);
> +            tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
>              break;

This doesn't work, because tci_write_reg8 truncates to uint8_t again.  You need
to use tci_write_reg().


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]