[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Introduce a battery, AC adapter, and lid button
From: |
Leonid Bloch |
Subject: |
Re: [PATCH 0/4] Introduce a battery, AC adapter, and lid button |
Date: |
Thu, 28 Jan 2021 08:02:57 +0200 |
On Tue, Jan 26, 2021 at 4:40 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> Poking at sysfs from QEMU poses a bunch of issues, for example,
> security, migration, etc. Running timers on the host is also not nice
> since it causes exits from VM ...
>
> So I agree, as a starting point let's just let user
> control the battery level through QMP.
>
Thanks for the review, Michael. Yep, I fully agree - indeed looking at
the host's battery is better to be left for the user, and QEMU should
just set what the guest sees. Will modify accordingly, and send a v2.
Cheers,
Leonid.
- [PATCH 0/4] Introduce a battery, AC adapter, and lid button, Leonid Bloch, 2021/01/20
- [PATCH 1/4] hw/acpi: Increase the number of possible ACPI interrupts, Leonid Bloch, 2021/01/20
- [PATCH 2/4] hw/acpi: Introduce the QEMU Battery, Leonid Bloch, 2021/01/20
- [PATCH 3/4] hw/acpi: Introduce the QEMU AC adapter, Leonid Bloch, 2021/01/20
- [PATCH 4/4] hw/acpi: Introduce the QEMU lid button, Leonid Bloch, 2021/01/20
- Re: [PATCH 0/4] Introduce a battery, AC adapter, and lid button, Philippe Mathieu-Daudé, 2021/01/20