[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass |
Date: |
Thu, 28 Jan 2021 14:03:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/28/21 10:28 AM, Claudio Fontana wrote:
> add a new optional interface to CPUClass,
> which allows accelerators to extend the CPUClass
> with additional accelerator-specific initializations.
>
> Add the field before tcg_ops, and mark tcg_ops as
> needing to be last in the struct until we rework this
> further in a later patch.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> include/hw/core/accel-cpu.h | 35 +++++++++++++++++++++++++++++
> include/hw/core/cpu.h | 1 +
> accel/accel-common.c | 44 +++++++++++++++++++++++++++++++++++++
> MAINTAINERS | 1 +
> 4 files changed, 81 insertions(+)
> create mode 100644 include/hw/core/accel-cpu.h
>
> diff --git a/include/hw/core/accel-cpu.h b/include/hw/core/accel-cpu.h
> new file mode 100644
> index 0000000000..246b3e2fcb
> --- /dev/null
> +++ b/include/hw/core/accel-cpu.h
> @@ -0,0 +1,35 @@
> +/*
> + * Accelerator interface, specializes CPUClass
> + *
> + * Copyright 2020 SUSE LLC
2020-2021 ;)
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#ifndef ACCEL_CPU_H
> +#define ACCEL_CPU_H
> +
> +/*
> + * these defines cannot be in cpu.h, because we are using
> + * CPU_RESOLVING_TYPE here.
> + * Use this header to define your accelerator-specific
> + * cpu-specific accelerator interfaces.
> + */
> +
> +#define TYPE_ACCEL_CPU "accel-" CPU_RESOLVING_TYPE
> +#define ACCEL_CPU_NAME(name) (name "-" TYPE_ACCEL_CPU)
> +typedef struct AccelCPUClass AccelCPUClass;
> +DECLARE_CLASS_CHECKERS(AccelCPUClass, ACCEL_CPU, TYPE_ACCEL_CPU)
> +
> +typedef struct AccelCPUClass {
> + /*< private >*/
> + ObjectClass parent_class;
> + /*< public >*/
> +
> + void (*cpu_class_init)(CPUClass *cc);
> + void (*cpu_instance_init)(CPUState *cpu);
> + void (*cpu_realizefn)(CPUState *cpu, Error **errp);
If we want callers to check errp, better have the prototype return
a boolean.
> +} AccelCPUClass;
- [PATCH v14 08/22] target/arm: do not use cc->do_interrupt for KVM directly, (continued)
- [PATCH v14 08/22] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2021/01/28
- [PATCH v14 01/22] cpu: Introduce TCGCpuOperations struct, Claudio Fontana, 2021/01/28
- [PATCH v14 10/22] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2021/01/28
- [PATCH v14 12/22] physmem: make watchpoint checking code TCG-only, Claudio Fontana, 2021/01/28
- [PATCH v14 11/22] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2021/01/28
- [PATCH v14 14/22] cpu: move debug_check_watchpoint to tcg_ops, Claudio Fontana, 2021/01/28
- [PATCH v14 09/22] cpu: move cc->do_interrupt to tcg_ops, Claudio Fontana, 2021/01/28
- [PATCH v14 16/22] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2021/01/28
- [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/01/28
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass,
Philippe Mathieu-Daudé <=
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/01/28
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Alex Bennée, 2021/01/28
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Philippe Mathieu-Daudé, 2021/01/28
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Richard Henderson, 2021/01/28
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/01/30
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass, Richard Henderson, 2021/01/30
[PATCH v14 13/22] cpu: move adjust_watchpoint_address to tcg_ops, Claudio Fontana, 2021/01/28
[PATCH v14 21/22] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn, Claudio Fontana, 2021/01/28
[PATCH v14 22/22] accel: introduce new accessor functions, Claudio Fontana, 2021/01/28
[PATCH v14 19/22] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/01/28