[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/23] tcg/tci: Implement INDEX_op_ld8s_i64
From: |
Alex Bennée |
Subject: |
Re: [PATCH 05/23] tcg/tci: Implement INDEX_op_ld8s_i64 |
Date: |
Thu, 28 Jan 2021 13:59:45 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> From: Stefan Weil <sw@weilnetz.de>
>
> That TCG opcode is used by debian-buster (arm64) running ffmpeg:
>
> qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Message-Id: <20210128020425.2055454-1-sw@weilnetz.de>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tcg/tci.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/tci.c b/tcg/tci.c
> index 2edb47506e..0e1b8e8383 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -882,7 +882,10 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
> *env,
> tci_write_reg8(regs, t0, *(uint8_t *)(t1 + t2));
> break;
> case INDEX_op_ld8s_i64:
> - TODO();
> + t0 = *tb_ptr++;
> + t1 = tci_read_r(regs, &tb_ptr);
> + t2 = tci_read_s32(&tb_ptr);
> + tci_write_reg(regs, t0, *(int8_t *)(t1 + t2));
> break;
> case INDEX_op_ld16u_i64:
> t0 = *tb_ptr++;
--
Alex Bennée
- [PATCH 04/23] tcg/tci: Implement INDEX_op_ld16s_i32, (continued)
- [PATCH 04/23] tcg/tci: Implement INDEX_op_ld16s_i32, Richard Henderson, 2021/01/28
- [PATCH 02/23] tcg: Manage splitwx in tc_ptr_to_region_tree by hand, Richard Henderson, 2021/01/28
- [PATCH 06/23] tcg/tci: Inline tci_write_reg32s into the only caller, Richard Henderson, 2021/01/28
- [PATCH 07/23] tcg/tci: Inline tci_write_reg8 into its callers, Richard Henderson, 2021/01/28
- [PATCH 05/23] tcg/tci: Implement INDEX_op_ld8s_i64, Richard Henderson, 2021/01/28
- Re: [PATCH 05/23] tcg/tci: Implement INDEX_op_ld8s_i64,
Alex Bennée <=
- [PATCH 08/23] tcg/tci: Inline tci_write_reg16 into the only caller, Richard Henderson, 2021/01/28
- [PATCH 09/23] tcg/tci: Inline tci_write_reg32 into all callers, Richard Henderson, 2021/01/28
- [PATCH 10/23] tcg/tci: Inline tci_write_reg64 into 64-bit callers, Richard Henderson, 2021/01/28
- [PATCH 11/23] tcg/tci: Merge INDEX_op_ld8u_{i32,i64}, Richard Henderson, 2021/01/28
- [PATCH 12/23] tcg/tci: Merge INDEX_op_ld8s_{i32,i64}, Richard Henderson, 2021/01/28