[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tests: Fix runtime error in test-authz-pam
From: |
Stefan Weil |
Subject: |
[PATCH] tests: Fix runtime error in test-authz-pam |
Date: |
Thu, 28 Jan 2021 18:11:27 +0100 |
A test with sanitizers on macOS shows this error:
authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1,
which is declared to never be null
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/security/pam_appl.h:56:2:
note: nonnull attribute specified here
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tests/test-authz-pam.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/test-authz-pam.c b/tests/test-authz-pam.c
index 1baeadee03..4fe1ef2603 100644
--- a/tests/test-authz-pam.c
+++ b/tests/test-authz-pam.c
@@ -28,7 +28,7 @@
static bool failauth;
/*
- * These two functions are exported by libpam.so.
+ * These three functions are exported by libpam.so.
*
* By defining them again here, our impls are resolved
* by the linker instead of those in libpam.so
@@ -50,6 +50,7 @@ pam_start(const char *service_name, const char *user,
failauth = false;
}
+ *pamh = (pam_handle_t *)0xbadeaffe;
return PAM_SUCCESS;
}
@@ -65,6 +66,13 @@ pam_acct_mgmt(pam_handle_t *pamh, int flags)
}
+int
+pam_end(pam_handle_t *pamh, int status)
+{
+ return PAM_SUCCESS;
+}
+
+
static void test_authz_unknown_service(void)
{
Error *local_err = NULL;
--
2.24.3 (Apple Git-128)
- [PATCH] tests: Fix runtime error in test-authz-pam,
Stefan Weil <=