Re: [PULL 00/46] target-arm queue

[no-reply]

Patchew URL: 
20210129110012.8660-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210129110012.8660-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210129110012.8660-1-peter.maydell@linaro.org
Subject: [PULL 00/46] target-arm queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   7e7eb9f..5101d00  master     -> master
 * [new tag]         patchew/20210129110012.8660-1-peter.maydell@linaro.org -> 
patchew/20210129110012.8660-1-peter.maydell@linaro.org
Switched to a new branch 'test'
e4eff82 hw/arm/stellaris: Remove board-creation reset of STELLARIS_SYS
5f7695b arm: Remove frq properties on CMSDK timer, dualtimer, watchdog, ARMSSE
61b34fd arm: Don't set freq properties on CMSDK timer, dualtimer, watchdog, 
ARMSSE
568ae2e hw/arm/armsse: Use Clock to set system_clock_scale
fcb2844 tests/qtest/cmsdk-apb-watchdog-test: Test clock changes
0e465a3 hw/watchdog/cmsdk-apb-watchdog: Convert to use Clock input
714ce6c hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input
a947916 hw/timer/cmsdk-apb-timer: Convert to use Clock input
e307bd8 hw/arm/stellaris: Create Clock input for watchdog
69adf23 hw/arm/stellaris: Convert SSYS to QOM device
103b89d hw/arm/musca: Create and connect ARMSSE Clocks
0350223 hw/arm/mps2-tz: Create and connect ARMSSE Clocks
0d30c31 hw/arm/mps2: Create and connect SYSCLK Clock
de9dbba hw/arm/mps2: Inline CMSDK_APB_TIMER creation
27ac1e9 hw/arm/armsse: Wire up clocks
9885628 hw/arm/armsse: Rename "MAINCLK" property to "MAINCLK_FRQ"
4d027bf hw/watchdog/cmsdk-apb-watchdog: Add Clock input
fc55f0a hw/timer/cmsdk-apb-dualtimer: Add Clock input
ab869a2 hw/timer/cmsdk-apb-timer: Add Clock input
e25a861 hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer
eb6abc6 tests: Add a simple test of the CMSDK APB dual timer
5aa5062 tests: Add a simple test of the CMSDK APB watchdog
7d74e5d tests: Add a simple test of the CMSDK APB timer
99411a9 clock: Add new clock_has_source() function
5fd09a8 ptimer: Add new ptimer_set_period_from_clock() function
36bda30 tests/qtest: add a test case for pvpanic-pci
ae9e986 pvpanic : update pvpanic spec document
2b579e1 hw/misc/pvpanic: add PCI interface support
16a85d3 hw/misc/pvpanic: split-out generic and bus dependent code
b01511c hvf: Add hypervisor entitlement to output binaries
ae4c601 darwin: remove 64-bit build detection on 32-bit OS
e9f538c darwin: detect CoreAudio for build
2f25d4a configure: cross compile should use x86_64 cpu_family
0bb8eeb darwin: fix cross-compiling for Darwin
9e6aa95 darwin: remove redundant dependency declaration
eaf3508 osdep: build with non-working system() function
83cd152 configure: cross-compiling with empty cross_prefix
69c2d85 configure: Move preadv check to meson.build
63f5cbe target/arm: Replace magic value by MMU_DATA_LOAD definition
447d650 hw/misc: Fix arith overflow in NPCM7XX PWM module
55b8e80 arm-virt: add secure pl061 for reset/power down
92ff23b arm-virt: refactor gpios creation
b50aad5 hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
e84395b arm: rename xlnx-zcu102.canbusN properties
1d12dd9 target/arm: Conditionalize DBGDIDR
11b098b target/arm: Implement ID_PFR2

=== OUTPUT BEGIN ===
1/46 Checking commit 11b098ba1811 (target/arm: Implement ID_PFR2)
2/46 Checking commit 1d12dd960d76 (target/arm: Conditionalize DBGDIDR)
3/46 Checking commit e84395bcb317 (arm: rename xlnx-zcu102.canbusN properties)
4/46 Checking commit b50aad50088a (hw: gpio: implement gpio-pwr driver for qemu 
reset/poweroff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 84 lines checked

Patch 4/46 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/46 Checking commit 92ff23b6fda5 (arm-virt: refactor gpios creation)
6/46 Checking commit 55b8e80c576a (arm-virt: add secure pl061 for reset/power 
down)
7/46 Checking commit 447d6508952e (hw/misc: Fix arith overflow in NPCM7XX PWM 
module)
8/46 Checking commit 63f5cbec4eda (target/arm: Replace magic value by 
MMU_DATA_LOAD definition)
9/46 Checking commit 69c2d852a523 (configure: Move preadv check to meson.build)
10/46 Checking commit 83cd15231abb (configure: cross-compiling with empty 
cross_prefix)
11/46 Checking commit eaf35083688d (osdep: build with non-working system() 
function)
12/46 Checking commit 9e6aa95cba9d (darwin: remove redundant dependency 
declaration)
13/46 Checking commit 0bb8eeb33670 (darwin: fix cross-compiling for Darwin)
14/46 Checking commit 2f25d4a2e787 (configure: cross compile should use x86_64 
cpu_family)
15/46 Checking commit e9f538c8046d (darwin: detect CoreAudio for build)
16/46 Checking commit ae4c601e2ff4 (darwin: remove 64-bit build detection on 
32-bit OS)
17/46 Checking commit b01511c00efb (hvf: Add hypervisor entitlement to output 
binaries)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

total: 0 errors, 1 warnings, 62 lines checked

Patch 17/46 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/46 Checking commit 16a85d3ef395 (hw/misc/pvpanic: split-out generic and bus 
dependent code)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#87: 
new file mode 100644

ERROR: line over 90 characters
#159: FILE: hw/misc/pvpanic-isa.c:68:
+    DEFINE_PROP_UINT8("events", PVPanicISAState, pvpanic.events, 
PVPANIC_PANICKED | PVPANIC_CRASHLOADED),

WARNING: line over 80 characters
#255: FILE: hw/misc/pvpanic.c:69:
+    memory_region_init_io(&s->mr, OBJECT(dev), &pvpanic_ops, s, "pvpanic", 
size);

total: 1 errors, 2 warnings, 238 lines checked

Patch 18/46 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/46 Checking commit 2b579e1074f2 (hw/misc/pvpanic: add PCI interface support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

ERROR: line over 90 characters
#129: FILE: hw/misc/pvpanic-pci.c:57:
+    DEFINE_PROP_UINT8("events", PVPanicPCIState, pvpanic.events, 
PVPANIC_PANICKED | PVPANIC_CRASHLOADED),

total: 1 errors, 1 warnings, 134 lines checked

Patch 19/46 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/46 Checking commit ae9e9861eee8 (pvpanic : update pvpanic spec document)
21/46 Checking commit 36bda303a417 (tests/qtest: add a test case for 
pvpanic-pci)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 21/46 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/46 Checking commit 5fd09a8f7a84 (ptimer: Add new 
ptimer_set_period_from_clock() function)
23/46 Checking commit 99411a915fca (clock: Add new clock_has_source() function)
24/46 Checking commit 7d74e5dff9e0 (tests: Add a simple test of the CMSDK APB 
timer)
25/46 Checking commit 5aa5062d8bdb (tests: Add a simple test of the CMSDK APB 
watchdog)
26/46 Checking commit eb6abc6a1f32 (tests: Add a simple test of the CMSDK APB 
dual timer)
27/46 Checking commit e25a8618b6d2 (hw/timer/cmsdk-apb-timer: Rename 
CMSDKAPBTIMER struct to CMSDKAPBTimer)
28/46 Checking commit ab869a2737f7 (hw/timer/cmsdk-apb-timer: Add Clock input)
29/46 Checking commit fc55f0aa68d3 (hw/timer/cmsdk-apb-dualtimer: Add Clock 
input)
30/46 Checking commit 4d027bf8ba02 (hw/watchdog/cmsdk-apb-watchdog: Add Clock 
input)
31/46 Checking commit 9885628292fd (hw/arm/armsse: Rename "MAINCLK" property to 
"MAINCLK_FRQ")
32/46 Checking commit 27ac1e9412e1 (hw/arm/armsse: Wire up clocks)
33/46 Checking commit de9dbbac8cc4 (hw/arm/mps2: Inline CMSDK_APB_TIMER 
creation)
34/46 Checking commit 0d30c31abee7 (hw/arm/mps2: Create and connect SYSCLK 
Clock)
35/46 Checking commit 035022338fda (hw/arm/mps2-tz: Create and connect ARMSSE 
Clocks)
36/46 Checking commit 103b89d35001 (hw/arm/musca: Create and connect ARMSSE 
Clocks)
37/46 Checking commit 69adf233fbec (hw/arm/stellaris: Convert SSYS to QOM 
device)
38/46 Checking commit e307bd835a08 (hw/arm/stellaris: Create Clock input for 
watchdog)
39/46 Checking commit a9479168f8e0 (hw/timer/cmsdk-apb-timer: Convert to use 
Clock input)
40/46 Checking commit 714ce6cf8b5f (hw/timer/cmsdk-apb-dualtimer: Convert to 
use Clock input)
41/46 Checking commit 0e465a3ae76f (hw/watchdog/cmsdk-apb-watchdog: Convert to 
use Clock input)
42/46 Checking commit fcb2844113a5 (tests/qtest/cmsdk-apb-watchdog-test: Test 
clock changes)
43/46 Checking commit 568ae2e471d2 (hw/arm/armsse: Use Clock to set 
system_clock_scale)
44/46 Checking commit 61b34fd1d20a (arm: Don't set freq properties on CMSDK 
timer, dualtimer, watchdog, ARMSSE)
45/46 Checking commit 5f7695b028b9 (arm: Remove frq properties on CMSDK timer, 
dualtimer, watchdog, ARMSSE)
46/46 Checking commit e4eff82a714f (hw/arm/stellaris: Remove board-creation 
reset of STELLARIS_SYS)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210129110012.8660-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210129110012.8660-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com