[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for t
|
From: |
Vivek Goyal |
|
Subject: |
Re: [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit |
|
Date: |
Fri, 29 Jan 2021 10:04:15 -0500 |
On Fri, Jan 29, 2021 at 01:03:09PM +0100, Greg Kurz wrote:
> On Tue, 26 Jan 2021 13:33:36 -0500
> Vivek Goyal <vgoyal@redhat.com> wrote:
>
> [...]
>
> > >
> > > Also, since pthread_rwlock_wrlock() can fail, I think we should
> > > always check it's return value, at least with an assert() like
> > > already done elsewhere.
> >
> > Will check return code of pthread_rwlock_wrlock() and probably use
> > assert().
> >
>
> It turns out that pthread_rwlock_rdlock() and pthread_rwlock_unlock() can
> also fail for various reasons that would likely indicate a programming
> error, but their return values are never checked anywhere.
>
> I have a patch to address this globally in this file. Should I post it
> now or you prefer this series goes first ?
Please go ahead and post your patch. Your patch can go first and I can
rebase my patches on top of yours.
Vivek
- Re: [PATCH 2/6] libvhost-user: Use slave_mutex in all slave messages, (continued)
[PATCH 6/6] virtiofsd: Opt in for slave start/stop/shutdown functionality, Vivek Goyal, 2021/01/25
[PATCH 3/6] vhost-user: Return error code from slave_read(), Vivek Goyal, 2021/01/25
[PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit, Vivek Goyal, 2021/01/25
[PATCH 4/6] qemu, vhost-user: Extend protocol to start/stop/flush slave channel, Vivek Goyal, 2021/01/25
[PATCH 5/6] libvhost-user: Add support to start/stop/flush slave channel, Vivek Goyal, 2021/01/25