[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/13] tests: Fix runtime error in test-authz-pam
From: |
Daniel P . Berrangé |
Subject: |
[PULL 12/13] tests: Fix runtime error in test-authz-pam |
Date: |
Fri, 29 Jan 2021 17:11:01 +0000 |
From: Stefan Weil <sw@weilnetz.de>
A test with sanitizers on macOS shows this error:
authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1,
which is declared to never be null
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/security/pam_appl.h:56:2:
note: nonnull attribute specified here
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/test-authz-pam.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/test-authz-pam.c b/tests/test-authz-pam.c
index 1baeadee03..4fe1ef2603 100644
--- a/tests/test-authz-pam.c
+++ b/tests/test-authz-pam.c
@@ -28,7 +28,7 @@
static bool failauth;
/*
- * These two functions are exported by libpam.so.
+ * These three functions are exported by libpam.so.
*
* By defining them again here, our impls are resolved
* by the linker instead of those in libpam.so
@@ -50,6 +50,7 @@ pam_start(const char *service_name, const char *user,
failauth = false;
}
+ *pamh = (pam_handle_t *)0xbadeaffe;
return PAM_SUCCESS;
}
@@ -65,6 +66,13 @@ pam_acct_mgmt(pam_handle_t *pamh, int flags)
}
+int
+pam_end(pam_handle_t *pamh, int status)
+{
+ return PAM_SUCCESS;
+}
+
+
static void test_authz_unknown_service(void)
{
Error *local_err = NULL;
--
2.29.2
- [PULL 02/13] crypto: Move USER_CREATABLE to secret_common base class, (continued)
- [PULL 02/13] crypto: Move USER_CREATABLE to secret_common base class, Daniel P . Berrangé, 2021/01/29
- [PULL 03/13] crypto: Forbid broken unloading of secrets, Daniel P . Berrangé, 2021/01/29
- [PULL 05/13] os: deprecate the -enable-fips option and QEMU's FIPS enforcement, Daniel P . Berrangé, 2021/01/29
- [PULL 06/13] Prefer 'on' | 'off' over 'yes' | 'no' for bool options, Daniel P . Berrangé, 2021/01/29
- [PULL 04/13] crypto: Fix memory leaks in set_loaded for tls-*, Daniel P . Berrangé, 2021/01/29
- [PULL 07/13] docs: simplify and clarify the platform support rules, Daniel P . Berrangé, 2021/01/29
- [PULL 08/13] docs: fix missing backslash in certtool shell example, Daniel P . Berrangé, 2021/01/29
- [PULL 09/13] configure: replace --enable/disable-git-update with --with-git-submodules, Daniel P . Berrangé, 2021/01/29
- [PULL 10/13] crypto: Add spaces around operator, Daniel P . Berrangé, 2021/01/29
- [PULL 11/13] ui: update keycodemapdb submodule commit, Daniel P . Berrangé, 2021/01/29
- [PULL 12/13] tests: Fix runtime error in test-authz-pam,
Daniel P . Berrangé <=
- [PULL 13/13] tests: Replace deprecated ASN1 code, Daniel P . Berrangé, 2021/01/29
- Re: [PULL 00/13] Misc patches, no-reply, 2021/01/29
- Re: [PULL 00/13] Misc patches, Peter Maydell, 2021/01/29