[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] simpletrace: build() missing 2 required positional arguments
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] simpletrace: build() missing 2 required positional arguments |
Date: |
Mon, 1 Feb 2021 10:51:11 +0000 |
On Sun, Jan 31, 2021 at 06:34:15PM +0100, Volker RĂ¼melin wrote:
> Commit 4e66c9ef64 "tracetool: add input filename and line number to
> Event" forgot to add a line number and a filename argument at one
> build method call site.
>
> Traceback (most recent call last):
> File "./scripts/simpletrace.py", line 261, in <module>
> run(Formatter())
> File "./scripts/simpletrace.py", line 236, in run
> process(events, sys.argv[2], analyzer, read_header=read_header)
> File "./scripts/simpletrace.py", line 177, in process
> dropped_event =
> Event.build("Dropped_Event(uint64_t num_events_dropped)")
> TypeError: build() missing 2 required positional arguments:
> 'lineno' and 'filename'
>
> Add the missing arguments.
>
> Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
> ---
> scripts/simpletrace.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] simpletrace: build() missing 2 required positional arguments,
Stefan Hajnoczi <=