[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/7] hw/xen: Make xen_shutdown_fatal_error() available out
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 5/7] hw/xen: Make xen_shutdown_fatal_error() available out of X86 HVM |
Date: |
Mon, 1 Feb 2021 14:09:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/1/21 12:29 PM, Philippe Mathieu-Daudé wrote:
> xen_shutdown_fatal_error() is also used by XEN_PV.
>
> This fixes when XEN_PV without XEN_FV:
>
> /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/hw_xen_xen_pt_config_init.c.o: in
> function `xen_pt_status_reg_init':
> hw/xen/xen_pt_config_init.c:281: undefined reference to
> `xen_shutdown_fatal_error'
> /usr/bin/ld: hw/xen/xen_pt_config_init.c:275: undefined reference to
> `xen_shutdown_fatal_error'
> /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/hw_xen_xen_pt.c.o: in function
> `xen_pt_pci_read_config':
> hw/xen/xen_pt.c:220: undefined reference to `xen_shutdown_fatal_error'
> /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/hw_xen_xen_pt.c.o: in function
> `xen_pt_pci_write_config':
> hw/xen/xen_pt.c:369: undefined reference to `xen_shutdown_fatal_error'
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/i386/xen/xen-hvm.c | 13 -------------
> hw/xen/xen-utils.c | 25 +++++++++++++++++++++++++
> hw/xen/meson.build | 1 +
> 3 files changed, 26 insertions(+), 13 deletions(-)
> create mode 100644 hw/xen/xen-utils.c
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index 7156ab13329..69196754a30 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -28,7 +28,6 @@
> #include "qemu/error-report.h"
> #include "qemu/main-loop.h"
> #include "qemu/range.h"
> -#include "sysemu/runstate.h"
^ self-nack, was not supposed to remove this.
> #include "sysemu/sysemu.h"
> #include "sysemu/xen.h"
> #include "trace.h"
> @@ -1570,18 +1569,6 @@ void xen_register_framebuffer(MemoryRegion *mr)
> framebuffer = mr;
> }
- [PATCH v3 0/7] hw/xen: Introduce XEN_FV/XEN_PV Kconfig, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 1/7] meson: Do not build Xen x86_64-softmmu on Aarch64, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 2/7] hw/xen: Relax dependency on FSDEV_9P, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 3/7] accel/xen: Incorporate xen-mapcache.c, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 4/7] hw/i386/xen: Introduce XEN_FV Kconfig, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 5/7] hw/xen: Make xen_shutdown_fatal_error() available out of X86 HVM, Philippe Mathieu-Daudé, 2021/02/01
- Re: [PATCH v3 5/7] hw/xen: Make xen_shutdown_fatal_error() available out of X86 HVM,
Philippe Mathieu-Daudé <=
- [PATCH v3 6/7] hw/xen: Make qmp_xen_set_global_dirty_log() available out of X86 HVM, Philippe Mathieu-Daudé, 2021/02/01
- [PATCH v3 7/7] NOTFORMERGE hw/xen/Kconfig: Introduce XEN_PV config, Philippe Mathieu-Daudé, 2021/02/01