Re: [PATCH 3/3] qmp: Resume OOB-enabled monitor before processing the request

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 01.02.2021 um 17:15 hat Markus Armbruster geschrieben:
>> monitor_qmp_dispatcher_co() needs to resume the monitor if
>> handle_qmp_command() suspended it.  Two cases:
>> 
>> 1. OOB enabled: suspended if mon->qmp_requests has no more space
>> 
>> 2. OOB disabled: suspended always
>> 
>> We resume only after we processed the request.  Which can take a long
>> time.
>> 
>> Resume the monitor right when the queue has space to keep the monitor
>> available for out-of-band commands even in this corner case.
>> 
>> Leave the "OOB disabled" case alone.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>> +        /*
>> +         * We need to resume the monitor if handle_qmp_command()
>> +         * suspended it.  Two cases:
>> +         * 1. OOB enabled: mon->qmp_requests has no more space
>> +         *    Resume right away, so that OOB commands can get executed while
>> +         *    this request is being processed.
>> +         * 2. OOB disabled: always
>> +         *    Resume only after we're done processing the request, 
>
> This line has trailing whitespace.

Trimming...

> With this fixed, the whole series is:
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Thanks!