[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] migration: Add blocker information
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 1/2] migration: Add blocker information |
|
Date: |
Tue, 2 Feb 2021 08:34:06 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/2/21 7:55 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Modify query-migrate so that it has a flag indicating if outbound
> migration is blocked, and if it is a list of reasons.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 25 +++++++++++++++++++++++--
> migration/savevm.c | 13 +++++++++++++
> migration/savevm.h | 1 +
> qapi/migration.json | 6 ++++++
> 4 files changed, 43 insertions(+), 2 deletions(-)
>
> +++ b/qapi/migration.json
> @@ -224,6 +224,10 @@
> # only returned if VFIO device is present, migration is supported by
> all
> # VFIO devices and status is 'active' or 'completed' (since 5.2)
> #
> +# @blocked: True if outgoing migration is blocked (since 6.0)
> +#
> +# @blocked-reasons: A list of reasons an outgoing migration is blocked
> (since 6.0)
A bit of redundancy here; the presence of blocked-reasons is sufficient
to tell if migration is blocked, without needing a bool. But having the
bool is more type-friendly for machines, so I don't mind having both.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org