Re: [PATCH v9 6/6] iotests: rename and move 169 and 199 tests

[Vladimir Sementsov-Ogievskiy]

02.02.2021 18:57, Daniel P. Berrangé wrote:
> On Mon, Jan 25, 2021 at 09:50:56PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Rename bitmaps migration tests and move them to tests subdirectory to
> > demonstrate new human-friendly test naming.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
> >   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
> >   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
> >   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
> >   4 files changed, 0 insertions(+), 0 deletions(-)
> >   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
> >   rename tests/qemu-iotests/{199.out => 
> > tests/migrate-bitmaps-postcopy-test.out} (100%)
> >   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
> >   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> >
> > diff --git a/tests/qemu-iotests/199 
> > b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > similarity index 100%
> > rename from tests/qemu-iotests/199
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > diff --git a/tests/qemu-iotests/199.out 
> > b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > similarity index 100%
> > rename from tests/qemu-iotests/199.out
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > diff --git a/tests/qemu-iotests/169 
> > b/tests/qemu-iotests/tests/migrate-bitmaps-test
> > similarity index 100%
> > rename from tests/qemu-iotests/169
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-test
> > diff --git a/tests/qemu-iotests/169.out 
> > b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
> > similarity index 100%
> > rename from tests/qemu-iotests/169.out
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
>
> Thanks for making tihs happen. It is great that we now have this
> feature and I can stop chasing conflicts on rebases !

You are welcome :)

> I converted my savevm series iotests to use the named test in the
> tests/ subdir, and hit a tiny issue that will affect any tests
> written in shell. They can't load config.common. I've included a
> possible fix for this problem here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg00627.html
>
>
> Regards,
> Daniel


--
Best regards,
Vladimir