|
From: | Markus Armbruster |
Subject: | Re: [PATCH v4 07/16] qapi: use explicitly internal module names |
Date: | Tue, 02 Feb 2021 21:43:00 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes: > On 2/2/21 4:16 AM, Markus Armbruster wrote: >> John Snow <jsnow@redhat.com> writes: >> >>> Use ./emit and ./init explicitly instead of "emit" and "init" and adding >>> the prefix based on the specific method called, which later allows us to >>> coalesce the two different methods into one. >> "Bandwurmsatz" (literally "tapeworm sentence"). Perhaps something >> like: >> QAPISchemaModularCVisitor._add_system_module() prefixes './' to >> its name >> argument to make it a module name. Pass the module name instead. This >> will allow us to coalesce the methods to add modules later on. >> Happy to tweak the commit message in my tree. >> > > Yep, with my blessing. Done!
[Prev in Thread] | Current Thread | [Next in Thread] |